False positive on int values: Comparison operation ">" between int<min, 6> and 10 is always false

[muxx]

Bug report

This is logic of validation OKPO number of companies in Russia.

Here example where you can see than $i can be greater 10 and logic is correct http://sandbox.onlinephpfunctions.com/code/afa48ae0eed6e2bc2407cd23984dbee39a962098

Code snippet that reproduces the problem

https://phpstan.org/r/10a2ec68-73ad-4c97-90eb-a792e86e0872

Expected output

Don't show error

Did PHPStan help you today? Did it make you happy in any way?

Yes, of course!)

[ondrejmirtes]

Hi, it'd help me if you debugged where PHPStan starts to get things wrong with the dumpType function like this: https://phpstan.org/r/06688a41-533c-43f2-986b-b44e42f6c828

[phpstan-bot]

@muxx After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-17: Comparison operation ">" between int<min, 6> and 10 is always false.
+ 3: Function okpoValidate() should return bool but return statement is missing.

Full report

Line	Error
3	Function okpoValidate() should return bool but return statement is missing.

[phpstan-bot]

@ondrejmirtes After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-15: Dumped type: int<min, 3>
-18: Comparison operation ">" between int<min, 6> and 10 is always false.
-23: Dumped type: int<min, 7>
-27: Dumped type: int<min, 7>
-33: Dumped type: int<min, 7>
+ 3: Function okpoValidate() should return bool but return statement is missing.

Full report

Line	Error
3	Function okpoValidate() should return bool but return statement is missing.

[muxx]

In version 1.* all ok!

[phpstan-bot]

@muxx After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-17: Comparison operation ">" between int<min, 6> and 10 is always false.
+17: Comparison operation ">" between int<1, 6> and 10 is always false.

Full report

Line	Error
17	Comparison operation ">" between int<1, 6> and 10 is always false.

[phpstan-bot]

@ondrejmirtes After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-15: Dumped type: int<min, 3>
-18: Comparison operation ">" between int<min, 6> and 10 is always false.
-23: Dumped type: int<min, 7>
-27: Dumped type: int<min, 7>
-33: Dumped type: int<min, 7>
+15: Dumped type: int<1, 3>
+18: Comparison operation ">" between int<1, 6> and 10 is always false.
+23: Dumped type: int<2, 7>
+27: Dumped type: int<1, 7>
+33: Dumped type: int<1, 7>

Full report

Line	Error
15	Dumped type: int<1, 3>
18	Comparison operation ">" between int<1, 6> and 10 is always false.
23	Dumped type: int<2, 7>
27	Dumped type: int<1, 7>
33	Dumped type: int<1, 7>

[phpstan-bot]

@muxx After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-17: Comparison operation ">" between int<min, 6> and 10 is always false.
+No errors

[phpstan-bot]

@ondrejmirtes After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-15: Dumped type: int<min, 3>
-18: Comparison operation ">" between int<min, 6> and 10 is always false.
-23: Dumped type: int<min, 7>
-27: Dumped type: int<min, 7>
-33: Dumped type: int<min, 7>
+15: Dumped type: 1|3
+23: Dumped type: int<2, 11>
+27: Dumped type: int<1, 11>
+33: Dumped type: int<1, 11>

Full report

Line	Error
15	`Dumped type: 1
23	Dumped type: int<2, 11>
27	Dumped type: int<1, 11>
33	Dumped type: int<1, 11>

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.