Bogus error when assigning to offset of ArrayObject<array<something>>

[dktapps]

Bug report

Code snippet that reproduces the problem

https://phpstan.org/r/fbafd268-227e-401e-9a26-47fcc9d8541f

Expected output

No error should be reported.

[phpstan-bot]

@dktapps After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-PHP 7.2 – 8.1 (1 error)
+PHP 7.2 – 8.1 (2 errors)
 ==========
 
+14: Static property AsyncTask::$threadLocalStorage (ArrayObject<int, array<string, mixed>>|null) does not accept ArrayObject<(int|string), mixed>.
 16: Static property AsyncTask::$threadLocalStorage (ArrayObject<int, array<string, mixed>>|null) does not accept non-empty-array<int, non-empty-array<string, mixed>>|ArrayObject<int, array<string, mixed>>.
 
-PHP 7.1 (3 errors)
+PHP 7.1 (4 errors)
 ==========
 
+14: Static property AsyncTask::$threadLocalStorage (ArrayObject<int, array<string, mixed>>|null) does not accept ArrayObject<(int|string), mixed>.
 16: Function spl_object_id not found.
 16: Static property AsyncTask::$threadLocalStorage (ArrayObject<int, array<string, mixed>>|null) does not accept non-empty-array<int|string, non-empty-array<string, mixed>>|ArrayObject<int, array<string, mixed>>.
 23: Function spl_object_id not found.

Full report

PHP 7.2 – 8.1 (2 errors)

Line	Error
14	`Static property AsyncTask::$threadLocalStorage (ArrayObject<int, array<string, mixed>>
16	`Static property AsyncTask::$threadLocalStorage (ArrayObject<int, array<string, mixed>>

PHP 7.1 (4 errors)

Line	Error
14	`Static property AsyncTask::$threadLocalStorage (ArrayObject<int, array<string, mixed>>
16	Function spl_object_id not found.
16	`Static property AsyncTask::$threadLocalStorage (ArrayObject<int, array<string, mixed>>
23	Function spl_object_id not found.

[dktapps]

welp

[ondrejmirtes]

Relaxed it a bit: phpstan/phpstan-src@089d4c6

[dktapps]

why is that change exclusive to bleeding-edge?

[ondrejmirtes]

Because it's a new and stricter behaviour that will be enabled for everyone in PHPStan 2.0.

[ondrejmirtes]

Another example https://phpstan.org/r/10bc4ea9-fe30-4211-9d2b-52dc7fef4dee

[phpstan-bot]

@dktapps After the latest push in 1.11.x, PHPStan now reports different result with your code snippet:

@@ @@
-PHP 7.2 – 8.1 (1 error)
-==========
-
-16: Static property AsyncTask::$threadLocalStorage (ArrayObject<int, array<string, mixed>>|null) does not accept non-empty-array<int, non-empty-array<string, mixed>>|ArrayObject<int, array<string, mixed>>.
-
-PHP 7.1 (3 errors)
-==========
-
-16: Function spl_object_id not found.
-16: Static property AsyncTask::$threadLocalStorage (ArrayObject<int, array<string, mixed>>|null) does not accept non-empty-array<int|string, non-empty-array<string, mixed>>|ArrayObject<int, array<string, mixed>>.
-23: Function spl_object_id not found.
+16: Static property AsyncTask::$threadLocalStorage (ArrayObject<int, array<string, mixed>>|null) does not accept non-empty-array<int, non-empty-array<string, mixed>>|ArrayObject<int, array<string, mixed>>.

Full report

Line	Error
16	`Static property AsyncTask::$threadLocalStorage (ArrayObject<int, array<string, mixed>>

[phpstan-bot]

@ondrejmirtes After the latest push in 2.0.x, PHPStan now reports different result with your code snippet:

@@ @@
-24: Property HelloWorld::$classLoaders ((ArrayObject<int, string>&iterable<string>)|null) does not accept array{string}|ArrayObject<int, string>.
+ 6: PHPDoc tag @var for property HelloWorld::$classLoaders with type array<string>|ArrayObject<int, string>|null is not subtype of native type ArrayObject|null.
+ 6: Property HelloWorld::$classLoaders with generic class ArrayObject does not specify its types: TKey, TValue
+24: Property HelloWorld::$classLoaders (ArrayObject|null) does not accept array<int, string>|ArrayObject.

Full report

Line	Error
6	`PHPDoc tag @var for property HelloWorld::$classLoaders with type array
6	Property HelloWorld::$classLoaders with generic class ArrayObject does not specify its types: TKey, TValue
24	`Property HelloWorld::$classLoaders (ArrayObject

[phpstan-bot]

@ondrejmirtes After the latest push in 2.0.x, PHPStan now reports different result with your code snippet:

@@ @@
-24: Property HelloWorld::$classLoaders ((ArrayObject<int, string>&iterable<string>)|null) does not accept array{string}|ArrayObject<int, string>.
+ 6: PHPDoc tag @var for property HelloWorld::$classLoaders with type array<string>|ArrayObject<int, string>|null is not subtype of native type ArrayObject|null.
+ 6: Property HelloWorld::$classLoaders with generic class ArrayObject does not specify its types: TKey, TValue
+24: Property HelloWorld::$classLoaders (ArrayObject|null) does not accept ArrayObject|list<string>.

Full report

Line	Error
6	`PHPDoc tag @var for property HelloWorld::$classLoaders with type array
6	Property HelloWorld::$classLoaders with generic class ArrayObject does not specify its types: TKey, TValue
24	`Property HelloWorld::$classLoaders (ArrayObject