Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offset 'dirname' of pathinfo function not always exists #8033

Closed
guvra opened this issue Sep 20, 2022 · 1 comment · Fixed by phpstan/phpstan-src#1734
Closed

Offset 'dirname' of pathinfo function not always exists #8033

guvra opened this issue Sep 20, 2022 · 1 comment · Fixed by phpstan/phpstan-src#1734

Comments

@guvra
Copy link

guvra commented Sep 20, 2022

Bug report

When calling pathinfo on an empty string, the function returns an array with only 2 keys:

  • basename
  • filename

Example:

php -r 'var_dump(pathinfo(""));'
Command line code:1:
array(2) {
  'basename' =>
  string(0) ""
  'filename' =>
  string(0) ""
}

On the other hand, phpstan expects this array to always contain the "dirname" offset.
So phpstan throws an error if we check whether dirname exists or not:

Code snippet that reproduces the problem

https://phpstan.org/r/fa3b7db7-5ce8-41d0-a63f-73742025ea3d

Expected output

PHPStan shouldn't detect an issue when we test whether the dirname offset exists.

@github-actions
Copy link

github-actions bot commented Oct 23, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant