PHPTAL errors out when given a empty string (or only an empty comment) to parse

[krionix1981]

Hi

Nasty code I wrote ages ago is

$template = new myPHPTAL('index.html');
...
try {
  $layout -> set('content', $template->execute() );
  echo $layout->execute();
)
catch {
 smth like mail to me
}

What I found is that if I have index.html like below (yes just a HTML comment, nothing else!)
<!-- -->
that makes the whole engine to fail with some fatal exception in PHPTAL class (sorry did not save it).

The whole catch block with PHP 82 and latest PHPTAL will not execute, will crash (not even triggering catch block but maybe it is poorly written - my bad). Replacing a comment with <span></span> would make my site working again!

It used to work with PHP 5.6 and 1.3.1 PHPTAL but just upgrading to latest + PHP 8.2 made the site crash due to this "template made of a comment".

Should not behave like that?

[Ocramius]

that makes the whole engine to fail with some fatal exception in PHPTAL class (sorry did not save it).

Well, that is not valid XML, right?

I'd certainly expect an exception though.

[Potherca]

This seems to be caused by PHPTAL_Dom_PHPTALDocumentBuilder::onDocumentEnd() expecting that $this->_stack is always set. As <!-- --> is effectively the same as feeding PHPTAL an empty string '', the stack is never instantiated.

This triggers a native PHP TypeError "Argument #1 ($value) must be of type Countable|array, null given", hence no PHPTAL Exception is thrown.

The simplest fix seems to be to either change the definition of PHPTAL_Dom_DocumentBuilder::$_stack to [] (rather than the current undefined)

PHPTAL/classes/PHPTAL/Dom/DocumentBuilder.php

Line 24 in 83359df

protected $_stack; /* array<PHPTAL_Dom_Node> */

or to add a check in PHPTAL_Dom_PHPTALDocumentBuilder::onDocumentEnd().

PHPTAL/classes/PHPTAL/Dom/PHPTALDocumentBuilder.php

Line 55 in 83359df

if (count($this->_stack) > 0) {

Either one works. @Ocramius Do you have a preference in this?