Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PHPTAL_lint to bin directoy #47

Merged
merged 6 commits into from
Oct 21, 2015
Merged

Adding PHPTAL_lint to bin directoy #47

merged 6 commits into from
Oct 21, 2015

Conversation

REBELinBLUE
Copy link
Contributor

Installs the lint tool in the composer bin directory.

I wasn't sure whether to rename phptal_lint.php to phptal_lint as other tools don't have the .php extension but I thought it was best to leave it for now in case anyone is using any test tools which expect tools/phptal_lint.php to exist

@Ocramius
Copy link
Member

@REBELinBLUE could you add an example lint command to the travis build? (after phpunit)

@REBELinBLUE
Copy link
Contributor Author

Do you mean like this?

@Ocramius
Copy link
Member

Looks good, yes :-)

@Ocramius
Copy link
Member

Linking #46

@Ocramius Ocramius added this to the v2.0.0 milestone Oct 18, 2015
@REBELinBLUE
Copy link
Contributor Author

👍

@Potherca
Copy link
Member

Looks good to me, if no one disagrees within the next 24 hours, I am merging this.

@REBELinBLUE
Copy link
Contributor Author

Oh crap, I thought it has been merged so I deleted my fork. Can it still be merged or do I need to re-create it?

@Ocramius
Copy link
Member

Should be fine anyway
On Oct 19, 2015 2:15 AM, "Stephen Ball" notifications@github.com wrote:

Oh crap, I thought it has been merged so I deleted my fork. Can it still
be merged or do I need to re-create it?


Reply to this email directly or view it on GitHub
#47 (comment).

Potherca added a commit that referenced this pull request Oct 21, 2015
Adding PHPTAL_lint to bin directoy
@Potherca Potherca merged commit 20849d3 into phptal:master Oct 21, 2015
@Ocramius Ocramius modified the milestones: 2.0.0, 1.5.0 Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants