Adding PHPTAL_lint to bin directoy#47
Merged
Merged
Conversation
Member
|
@REBELinBLUE could you add an example lint command to the travis build? (after phpunit) |
Contributor
Author
|
Do you mean like this? |
Member
|
Looks good, yes :-) |
Member
|
Linking #46 |
Contributor
Author
|
👍 |
Member
|
Looks good to me, if no one disagrees within the next 24 hours, I am merging this. |
Contributor
Author
|
Oh crap, I thought it has been merged so I deleted my fork. Can it still be merged or do I need to re-create it? |
Member
|
Should be fine anyway
|
Potherca
added a commit
that referenced
this pull request
Oct 21, 2015
Adding PHPTAL_lint to bin directoy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installs the lint tool in the composer bin directory.
I wasn't sure whether to rename
phptal_lint.phptophptal_lintas other tools don't have the .php extension but I thought it was best to leave it for now in case anyone is using any test tools which expecttools/phptal_lint.phpto exist