Make sure the locales used in the tests are installed in the Travis environment - #50
Merged
Merged
Conversation
Potherca
added a commit
that referenced
this pull request
Mar 21, 2016
Make sure the locales used in the tests are installed in the Travis environment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As became apparent in #49, "something" changed in the Travis-CI environment that caused the build to break because tests suddenly started failing.
This seemed to have something to do with the locales. Listing all of the locales installed on the Travis machine corroborated this:
The most simple solution seemed to be: making sure all of the needed locales were available by explicitly installing them. This can easily be achieved by adding the install commands to the Travis configuration file, in a
before_scriptstep.This pull request does that.
@Ocramius Are we good to merge, or did I miss anything?