Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the locales used in the tests are installed in the Travis environment #50

Merged
merged 1 commit into from Mar 21, 2016

Conversation

Potherca
Copy link
Member

As became apparent in #49, "something" changed in the Travis-CI environment that caused the build to break because tests suddenly started failing.

This seemed to have something to do with the locales. Listing all of the locales installed on the Travis machine corroborated this:

$ locale -a
C
C.UTF-8
en_US.utf8
POSIX
pt_BR.utf8
pt_PT.utf8

The most simple solution seemed to be: making sure all of the needed locales were available by explicitly installing them. This can easily be achieved by adding the install commands to the Travis configuration file, in a before_script step.

This pull request does that.

@Ocramius Are we good to merge, or did I miss anything?

Potherca added a commit that referenced this pull request Mar 21, 2016
Make sure the locales used in the tests are installed in the Travis environment
@Potherca Potherca merged commit b833d8f into phptal:1.3.x Mar 21, 2016
@Potherca Potherca deleted the feature/fix-travis-build branch March 21, 2016 13:10
@Potherca Potherca restored the feature/fix-travis-build branch March 21, 2016 13:12
@Potherca Potherca deleted the feature/fix-travis-build branch March 21, 2016 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant