Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.1 support, drop PHP 7.3 #89

Merged
merged 1 commit into from
Dec 17, 2021
Merged

Add PHP 8.1 support, drop PHP 7.3 #89

merged 1 commit into from
Dec 17, 2021

Conversation

Slamdunk
Copy link
Contributor

No description provided.

@@ -22,10 +22,10 @@
}
],
"require": {
"php": "^7.3 || ^8.0"
"php": "~7.4.0 || ~8.0.0 || ~8.1.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's too late to be restrictive on the upper bound, but better late then never, no?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aye: sad truth about php-src, heh.

@Potherca just FYI, PHP breaks compatibility in every damn minor release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I've been through a few of those... been developing in PHP since 2002... 😢

@Ocramius Ocramius self-assigned this Dec 17, 2021
@Ocramius Ocramius added this to the 1.6.0 milestone Dec 17, 2021
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@Ocramius
Copy link
Member

Adjusted branch protection rules: 🚢

@Ocramius Ocramius merged commit efddaab into phptal:1.6.x Dec 17, 2021
@Ocramius
Copy link
Member

Thanks @Slamdunk!

@Slamdunk Slamdunk deleted the php_81 branch December 17, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants