Add PHP 8.2 support, drop PHP 7.4#90
Merged
Ocramius merged 4 commits intophptal:1.7.xfrom Sep 16, 2022
Merged
Conversation
Slamdunk
commented
Sep 16, 2022
| if (version_compare(PHP_VERSION, '5.4.0') < 0) $this->markTestSkipped('PHP < 5.4'); | ||
|
|
||
| ini_set('short_open_tag', 0); | ||
| if (ini_get('short_open_tag')) $this->markTestSkipped("PHP is buggy"); |
Contributor
Author
There was a problem hiding this comment.
Honestly I can't get what testPHPBlock54 should test, but this seems now needed to get it pass
Ocramius
requested changes
Sep 16, 2022
Contributor
Author
|
I admit I've done the minimal effort to get the tests pass because code quality without CSFix & SA tools is a pain. I'm undecided between answering your change requests with "Ain't nobody got time for that" or "Ok but only with |
Member
|
@Slamdunk I would just make sure we improve what we can, without breaking BC. I've done hundreds of these patches on |
Ocramius
requested changes
Sep 16, 2022
Member
|
I'll remove the 7.4 pipeline requirement once ready and releasable 👍 |
Member
|
Released: https://github.com/phptal/PHPTAL/releases/tag/1.7.0 Thanks @Slamdunk! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.