Add PHP 8.2 support, drop PHP 7.4 #90
Conversation
| @@ -297,6 +297,9 @@ public function testPHPBlock54() | |||
| { | |||
| if (version_compare(PHP_VERSION, '5.4.0') < 0) $this->markTestSkipped('PHP < 5.4'); | |||
|
|
|||
| ini_set('short_open_tag', 0); | |||
| if (ini_get('short_open_tag')) $this->markTestSkipped("PHP is buggy"); | |||
There was a problem hiding this comment.
Honestly I can't get what testPHPBlock54 should test, but this seems now needed to get it pass
There was a problem hiding this comment.
@Potherca do you perhaps know what's going on here?
|
I admit I've done the minimal effort to get the tests pass because code quality without CSFix & SA tools is a pain. I'm undecided between answering your change requests with "Ain't nobody got time for that" or "Ok but only with |
|
@Slamdunk I would just make sure we improve what we can, without breaking BC. I've done hundreds of these patches on |
|
I'll remove the 7.4 pipeline requirement once ready and releasable 👍 |
|
Released: https://github.com/phptal/PHPTAL/releases/tag/1.7.0 Thanks @Slamdunk! |
No description provided.