Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failures on V8 5.9.35 #302

Closed
stesie opened this issue Mar 13, 2017 · 0 comments · Fixed by #303
Closed

Test failures on V8 5.9.35 #302

stesie opened this issue Mar 13, 2017 · 0 comments · Fixed by #303

Comments

@stesie
Copy link
Member

stesie commented Mar 13, 2017

This test fails, since V8 now returns a different column number

=====================================================================
FAILED TEST SUMMARY
---------------------------------------------------------------------
Test V8::executeString() : Test getJsStartColumn on script exception [tests/exception_start_column.phpt]
=====================================================================
stesie added a commit to stesie/v8js that referenced this issue Mar 14, 2017
@stesie
make exception_start_column.phpt green again, closes phpv8#302
54e3a07 
Test began to fail with V8 ~5.9.35 which started to report different
column numbers of errors.  Adapt test so it works well with older
and newer versions of V8.
@stesie stesie mentioned this issue Mar 14, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes test on V8 5.9.35 stesie/v8js
1 participant
@stesie