-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch to support Virtualbox 5.1 #22
Conversation
Changed version string to 5.1
The wsdl files created from virtualbox 5.1
old version removed.
old version removed
| @@ -5,7 +5,7 @@ | |||
| Generator: src/VBox/Main/webservice/websrv-wsdl-service.xsl | |||
| --> | |||
| <definitions xmlns:interface="urn:vbox" xmlns:soap="http://schemas.xmlsoap.org/wsdl/soap/" xmlns:vbox="http://www.virtualbox.org/" xmlns="http://schemas.xmlsoap.org/wsdl/" name="VirtualBox" targetNamespace="http://www.virtualbox.org/Service"> | |||
| <import location="vboxweb-5.0.wsdl" namespace="http://www.virtualbox.org/"/> | |||
| <import location="vboxweb.wsdl" namespace="http://www.virtualbox.org/"/> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you either made a typo here and it should have be changed to -5.1 or you have a symlink since the file referenced here is currently in the repo and your PR does not create it. Just thought I'd mention it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are right. Sorry for this.
I copied the generated files from virtualbox and while testing I had both files (vboxweb.wsdl and vboxweb-5.1wdsl) in the directory.
fixed wrong import location.
|
@imoore76 Can we get this merged please? These patches have been around for while and I don't think we've seen any fallout. |
|
imoore76 is a long time not around, seems we must patch our self till he returns. I wish it was otherwise as I think a lot of us do wait for an 5.1 release. Also weird is that he does not replay on emails either. |
|
Someone of us should just fork it. Then we'll maintain it ourselves. Just
add a reference to this unmaintained repo out of good will... anyone wants
to fork it?
Op do 26 jan. 2017 00:58 schreef zoon01 <notifications@github.com>:
imoore76 is a long time not around, seems we must patch our self till he
returns. I wish it was otherwise as I think a lot of us do wait for an 5.1
release. Also weird is that he does not replay on emails either.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#22 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AM4oQMDMH-k5TX7kGKRtouqp8_sWZah0ks5rV-GegaJpZM4J8I64>
.
--
Met vriendelijke groet,
E. Holm
|
|
Please, do it. |
|
https://github.com/ezraholm50/phpvirtualbox/ Please post in the issue section if I should add you to the collaborators. |
|
So, does this work for you with 5.1.18 ? I've been struggling to get 5.0.5 tar.gz and apply this patch and get it working for a while now with no luck. When Creating a machine I get rc=0x80004004. with the message "Cannot create the machine folder dex in the parent folder /home/vbox/.VirtualBox/Machines." |
|
bump, can we merge this? |
|
ok, as it seems this repo is as fucked up as the sourceforge one. Going to work on my own. Too bad |
Sadly upstream is very silent and has not released a new version which supports VirtualBox 5.1, supports PHP 7.1 or fixes bugs. In the meantime the community has created patches which are collected in the github projects bugtracker and pull requests. This unofficial version cherry picks the useful stuff of it. Highlights of unofficial phpvirtualbox 5.1-1: * based on git commit 65ebced (latest commit from May 19, 2016) * Patch to support Virtualbox 5.1 phpvirtualbox/phpvirtualbox#22 * Fix argument count mismatches revealed by PHP 7.1 phpvirtualbox/phpvirtualbox#24 * Make decryption of images/VMs work by not providing a password ID phpvirtualbox/phpvirtualbox#55 * Tried to make clearOnSuspend work phpvirtualbox/phpvirtualbox#57 PR: ports/220171 Submitted By: rozhuk.im With hat: vbox@ (kind of) git-svn-id: svn+ssh://svn.freebsd.org/ports/head@446746 35697150-7ecd-e111-bb59-0022644237b5
Sadly upstream is very silent and has not released a new version which supports VirtualBox 5.1, supports PHP 7.1 or fixes bugs. In the meantime the community has created patches which are collected in the github projects bugtracker and pull requests. This unofficial version cherry picks the useful stuff of it. Highlights of unofficial phpvirtualbox 5.1-1: * based on git commit 65ebced (latest commit from May 19, 2016) * Patch to support Virtualbox 5.1 phpvirtualbox/phpvirtualbox#22 * Fix argument count mismatches revealed by PHP 7.1 phpvirtualbox/phpvirtualbox#24 * Make decryption of images/VMs work by not providing a password ID phpvirtualbox/phpvirtualbox#55 * Tried to make clearOnSuspend work phpvirtualbox/phpvirtualbox#57 PR: ports/220171 Submitted By: rozhuk.im With hat: vbox@ (kind of)
|
Sorry. This has been superceded by Pull request #66 Although we should probably look at making a version that is a little more agnostic to allow for phpvirtualbox to be at least a little out of sync. |
Sadly upstream is very silent and has not released a new version which supports VirtualBox 5.1, supports PHP 7.1 or fixes bugs. In the meantime the community has created patches which are collected in the github projects bugtracker and pull requests. This unofficial version cherry picks the useful stuff of it. Highlights of unofficial phpvirtualbox 5.1-1: * based on git commit 65ebced (latest commit from May 19, 2016) * Patch to support Virtualbox 5.1 phpvirtualbox/phpvirtualbox#22 * Fix argument count mismatches revealed by PHP 7.1 phpvirtualbox/phpvirtualbox#24 * Make decryption of images/VMs work by not providing a password ID phpvirtualbox/phpvirtualbox#55 * Tried to make clearOnSuspend work phpvirtualbox/phpvirtualbox#57 PR: ports/220171 Submitted By: rozhuk.im With hat: vbox@ (kind of)
Support for Virtualbox 5.1.
Seems that there was no change in the API.
Updating the version number and adding the vbox wsdl files from virtualbox 5.1 seems to work.