Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix argument count mismatches revealed by PHP 7.1 #24

Merged
merged 1 commit into from
Oct 26, 2017
Merged

Fix argument count mismatches revealed by PHP 7.1 #24

merged 1 commit into from
Oct 26, 2017

Conversation

mikedld
Copy link
Contributor

@mikedld mikedld commented Jan 14, 2017

I've upgraded to PHP 7.1 recently and phpvirtualbox stopped working because of errors (which were only warnings before). This fixes as much as I stumbled upon during limited testing. If not enough, should at least help someone else to get started.

Copy link

@zoon01 zoon01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly now with php 7.1.1

Copy link

@tva94 tva94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!

@BR0kEN- BR0kEN- mentioned this pull request May 5, 2017
h6w added a commit that referenced this pull request May 8, 2017
…ewer

Patch contributed for #24 Allow usage of SparkGateway or Guacamole instead of Java viewer
uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request Jul 27, 2017
Sadly upstream is very silent and has not released a new version
which supports VirtualBox 5.1, supports PHP 7.1 or fixes bugs. In
the meantime the community has created patches which are
collected in the github projects bugtracker and pull requests.
This unofficial version cherry picks the useful stuff of it.

Highlights of unofficial phpvirtualbox 5.1-1:

* based on git commit 65ebced (latest commit from May 19, 2016)

* Patch to support Virtualbox 5.1
phpvirtualbox/phpvirtualbox#22

* Fix argument count mismatches revealed by PHP 7.1
phpvirtualbox/phpvirtualbox#24

* Make decryption of images/VMs work by not providing a password ID
phpvirtualbox/phpvirtualbox#55

* Tried to make clearOnSuspend work
phpvirtualbox/phpvirtualbox#57

PR:		ports/220171
Submitted By:	rozhuk.im
With hat:	vbox@ (kind of)


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@446746 35697150-7ecd-e111-bb59-0022644237b5
uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request Jul 27, 2017
Sadly upstream is very silent and has not released a new version
which supports VirtualBox 5.1, supports PHP 7.1 or fixes bugs. In
the meantime the community has created patches which are
collected in the github projects bugtracker and pull requests.
This unofficial version cherry picks the useful stuff of it.

Highlights of unofficial phpvirtualbox 5.1-1:

* based on git commit 65ebced (latest commit from May 19, 2016)

* Patch to support Virtualbox 5.1
phpvirtualbox/phpvirtualbox#22

* Fix argument count mismatches revealed by PHP 7.1
phpvirtualbox/phpvirtualbox#24

* Make decryption of images/VMs work by not providing a password ID
phpvirtualbox/phpvirtualbox#55

* Tried to make clearOnSuspend work
phpvirtualbox/phpvirtualbox#57

PR:		ports/220171
Submitted By:	rozhuk.im
With hat:	vbox@ (kind of)
@h6w h6w merged commit 0290102 into phpvirtualbox:develop Oct 26, 2017
@h6w
Copy link
Collaborator

h6w commented Oct 26, 2017

ech 7.1 looks messy. So many unnecessary nulls!

svmhdvn pushed a commit to svmhdvn/freebsd-ports that referenced this pull request Jan 10, 2024
Sadly upstream is very silent and has not released a new version
which supports VirtualBox 5.1, supports PHP 7.1 or fixes bugs. In
the meantime the community has created patches which are
collected in the github projects bugtracker and pull requests.
This unofficial version cherry picks the useful stuff of it.

Highlights of unofficial phpvirtualbox 5.1-1:

* based on git commit 65ebced (latest commit from May 19, 2016)

* Patch to support Virtualbox 5.1
phpvirtualbox/phpvirtualbox#22

* Fix argument count mismatches revealed by PHP 7.1
phpvirtualbox/phpvirtualbox#24

* Make decryption of images/VMs work by not providing a password ID
phpvirtualbox/phpvirtualbox#55

* Tried to make clearOnSuspend work
phpvirtualbox/phpvirtualbox#57

PR:		ports/220171
Submitted By:	rozhuk.im
With hat:	vbox@ (kind of)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants