Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Improvements in performance and methods. #28

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
2 participants

The code needs a good organization and formatting. I did not commit this as it may be your personal taste.

The variables could be summarized in only one inline var.

I like to give preference to single quotes, but it is also personal taste.

If you want I can make those changes, thus encouraging me to contribute more to the project.

Hug.

Owner

phstc commented Apr 6, 2013

Hey @wbotelhos, tks for the PR.

Could you update it? It can't be automatically merge.

This pull request cannot be automatically merged.

Is test suite Test.html still passing?

Owner

phstc commented May 24, 2013

ping?

Hi @phstc,

Let's close it.
Now it is impossible to merge, you took to long to accept it.
Maybe tonight I do it again.

@wbotelhos wbotelhos closed this May 24, 2013

Owner

phstc commented May 24, 2013

Now it is impossible to merge, you took to long to accept it.

Sorry, I was a little away for this project. Could you help me? I sent an email to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment