New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add delay option into Shoryuken.add_group #543
Merged
phstc
merged 17 commits into
ruby-shoryuken:master
from
pizza-planet:feature/add_delay_into_group_interface
Jan 6, 2019
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
7fb0fb7
add delay option into add_group
db172a8
environment loader, tests, Polling::QueueConfiguration.delay update
931eae7
add .to_f, fix code climate
5d579f2
one liner for delay
e6b624f
might fix code climate
eed9bc6
lol, it sure did not pass code climate
b595819
found some hidden failures. should pass with bundle exec rspec now
d34ad42
code climate fix for delay(queue)
976d95a
from queue string to group delay
d41d053
Delete .byebug_history
37e59be
add delay into worker manager and polling base
4b8dba9
Merge branch 'feature/add_delay_into_group_interface' of github.com:l…
a2ae546
use Shoryuken.options.delay(group)
46e3d64
testing a private method, but checking if code climate is fixed
7dcc0af
Revert "use Shoryuken.options.delay(group)"
8f8dea3
Shoryuken::Options.delay(group) is right
6f97035
don't make delay private anymore
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made
delay
public and wrote some tests for it on each polling strategy.