Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce visibility to private for some functions #87

14 tasks done
phsym opened this issue Sep 19, 2018 · 0 comments
14 tasks done

Reduce visibility to private for some functions #87

phsym opened this issue Sep 19, 2018 · 0 comments


Copy link

phsym commented Sep 19, 2018

Many functions today are public and visible to crate's users. Their usage is internal to the crate and they should be private instead.

As an example, this has already been reported in #57.

Let's warn users by deprecating them in a first time, and give them time to bring feedback if they eventually use some of those functions

This will have the advantages of simplifying the API and its documentation, and removing those internal functions from public API will make it easier to introduce bigger changes without breaking the public API.
After making them private, they can still be brought back to public later if needed.

List of deprecated function:

  • Cell::print
  • Cell::print_term
  • Cell::get_height
  • Cell::get_width
  • LineSeparator::print (Already deprecrated. Now changed to private)
  • TableFormat::print_line_separator
  • TableFormat::print_column_separator
  • TableSlice::get_column_num
  • Table::get_column_num
  • Row::column_count
  • Row::get_height
  • Row::get_column_width
  • Row::print
  • Row::print_term

If you already use some of the deprecated functions, and want them to stay public, let me know in comments

@phsym phsym added this to the v0.8.0 milestone Sep 19, 2018
@phsym phsym self-assigned this Sep 19, 2018
@phsym phsym modified the milestones: v0.8.0, V0.9.0 Sep 23, 2018
@phsym phsym pinned this issue Aug 25, 2019
@phsym phsym closed this as completed Aug 26, 2019
@pinkforest pinkforest unpinned this issue Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

No branches or pull requests

1 participant