Html and Evcxr integration #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
=========================================
+ Coverage 84.11% 85.6% +1.49%
=========================================
Files 5 5
Lines 1177 1327 +150
=========================================
+ Hits 990 1136 +146
- Misses 187 191 +4
Continue to review full report at Codecov.
|
phsym
reviewed
Aug 25, 2019
* Add a HTML escaper to the utils class.
* Expand TableSlice, Row, and Cell with HTML printing functions.
These are implemented from scratch as they share almost nothing with
the line based printing used for text, as HTML directly supports
multiline cells.
* Add tests to Cell and Table which test the new functionality.
* Add optional feature for Evcxr integration
* Implement trait for everything which can be converted into a
Tableslice. The trait prints the Tableslice in plain-text and HTML
format in a Evcxr compatible manner.
|
@phsym I updated the readme as well. I hope you are fine with embedding the picture into the readme. If not, feel free to edit this PR appropriately. |
phsym
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR provides integration with Evcxr in two steps. If you do not know Evcxr, it is a Rust REPL and Jupyter kernel.
The first commit provides HTML output implementations for Cell, Row, and TableSlice. I tried to support all the styling features available. If I missed some, I can fix that.
The second commit provides optional integration with Evcxr via a off by default feature. Evcxr can display any type which has a
evcxr_display(). The output must be formatted a certain way, e.g., theEVCXR_BEGIN_CONTENTheader, and supports different MIME types. The different MIME types are helpful for CLI and Jupyter usage. A user only needs to enable the feature flag an importuse prettytable::evcxr::*;.I mage the feature off by default, because I was not sure, if the additional trait would be wanted by default. It is a small trait and implementation (as seen in
evcxr.rs).Here is a Screenshot how it looks in Jupyter with Evcxr Rust kernel:
