Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display of empty tables #127

Merged
merged 2 commits into from Dec 27, 2022
Merged

Conversation

nschoellhorn
Copy link
Contributor

@nschoellhorn nschoellhorn commented May 31, 2020

Before this patch, empty tables with titles were displayed very "buggy", no titles were shown and only some lines were drawn. With this patch, the titles appear and the body looks empty.

This is how tables with titles but no body looked before:

++
||
++
++

After this patch, the same table would look like this:

+---------+---------+
| Title 1 | Title 2 |
+---------+---------+
+---------+---------+

Before this patch, empty tables with titles were displayed very "buggy", no titles were shown and only some lines were drawn. With this patch, the titles appear and the body looks empty.
@codecov
Copy link

codecov bot commented May 31, 2020

Codecov Report

Merging #127 into master will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   85.89%   86.03%   +0.13%     
==========================================
  Files           5        5              
  Lines        1326     1339      +13     
==========================================
+ Hits         1139     1152      +13     
  Misses        187      187              
Impacted Files Coverage Δ
src/lib.rs 87.87% <100.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf7dca3...e2be609. Read the comment docs.

@pinkforest
Copy link
Collaborator

Thanks sounds reasonable for 1.0.0

@pinkforest pinkforest merged commit 051bfb0 into phsym:master Dec 27, 2022
@pinkforest pinkforest mentioned this pull request Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants