New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference `docker exec` in "Running a command in an existing container" section #168

Closed
johnpancoast opened this Issue Nov 21, 2014 · 3 comments

Comments

Projects
None yet
3 participants
@johnpancoast

johnpancoast commented Nov 21, 2014

I'm new to docker so I could definitely be missing something but couldn't the Running a command in an existing container section reference the docker exec command?

@endersonmaia

This comment has been minimized.

Show comment
Hide comment
@endersonmaia

endersonmaia Nov 21, 2014

Contributor

I've sent a PR for removing even ssh in favor of docker exec, see #161

Yes, you could provide another PR with just the added content for docker exec.

docker exec is only available from >= 1.3, and Docker is evolving very fast, and it's hard to keep everything up to date!

Contributor

endersonmaia commented Nov 21, 2014

I've sent a PR for removing even ssh in favor of docker exec, see #161

Yes, you could provide another PR with just the added content for docker exec.

docker exec is only available from >= 1.3, and Docker is evolving very fast, and it's hard to keep everything up to date!

@johnpancoast

This comment has been minimized.

Show comment
Hide comment
@johnpancoast

johnpancoast Nov 21, 2014

Docker is evolving very fast, and it's hard to keep everything up to date!

Figured that was the case!

johnpancoast commented Nov 21, 2014

Docker is evolving very fast, and it's hard to keep everything up to date!

Figured that was the case!

@FooBarWidget

This comment has been minimized.

Show comment
Hide comment
@FooBarWidget

FooBarWidget Jan 16, 2015

Member

Sorry responding so late, we're at small team at Phusion and it's been way too busy the past few months. I've finally come around to investigating docker exec.

I've found that docker exec is just a thin wrapper around nsenter, though with a few changes. Most of the usual cons of nsenter still applies. Therefore, I think it's not a good idea to remove SSH entirely in favor of docker exec. What we can do is replacing nsenter with docker exec, and disabling SSH by default. I've begun work on this.

Member

FooBarWidget commented Jan 16, 2015

Sorry responding so late, we're at small team at Phusion and it's been way too busy the past few months. I've finally come around to investigating docker exec.

I've found that docker exec is just a thin wrapper around nsenter, though with a few changes. Most of the usual cons of nsenter still applies. Therefore, I think it's not a good idea to remove SSH entirely in favor of docker exec. What we can do is replacing nsenter with docker exec, and disabling SSH by default. I've begun work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment