Closed
Conversation
Contributor
Author
|
This appears to be obsolete since I ran with Ruby 3.2.4 and got a single (different) test failure on the |
Contributor
Author
|
Also for any folks interested in converting to use Faraday, it looks like there is a fork that has some changes around that: master...stepful:frontapp:master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, we've been using this project for some time and it has served us well. Thank you for creating it!
Background: I'm trying to convert this gem's HTTP stack to use Faraday as an experiment / learning opportunity (and to potentially be able to take advantage of Faraday's middleware for retries since we've been getting a decent amount of 502/504 errors from Front).
As a first step, wanted to make sure that I could run the test suite. However, after getting on Ruby 3.1.2, I saw a few errors/failures as I ran
rspec.This PR just makes the test suite green (at least on my computer). Would this be helpful for this project? Thanks!