Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
There should be a way to cancel WebSocket connections upon restart #1200
Currently, WebSocket connections are not aborted on a restart. This prevents the process from properly restarting because we first wait for all connections to terminate. We solve this for Meteor by terminating Meteor with SIGTERM but we can't do this with Ruby and Node.js, where not all requests are WebSocket/long-polling requests.
I suggest the following solution:
[ ] Upon restarting a process, have RequestHandler terminate all WebSocket-upgraded connections.
Hey @FooBarWidget, I came from this post in the mailing list: https://groups.google.com/forum/#!topic/phusion-passenger/vWxWI-iqH1w
I saw this was milestone as 4.0.49 beta 1, is this release yet?(since stable is now on 4.0.50)
We run a big meteor app, with many users, and deploying our app currently involves 1 minute hang and can potentially breaks the hanging method call.
I've implemented a temporary solution until 5.0 is out. Please read https://github.com/phusion/passenger/wiki/Phusion-Passenger:-Node.js-tutorial#restarting_apps_that_serve_long_running_connections for more information.