New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passenger should start setting X-Forwarded-Proto for NodeJS requests again #1231

Closed
rolftimmermans opened this Issue Jul 9, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@rolftimmermans

rolftimmermans commented Jul 9, 2014

I have sent a message to the mailing list about this yesterday and have come to the conclusion there is a regression in Passenger, specifically this commit: d3fe176.

Previously it was possible to detect if a request came over an SSL/TLS connection, because the NodeJS handler would set the X-Forwarded-Proto header. Since the major NodeJS changes this no longer happens. It now seems impossible to tell if Apache/Nginx was serving the request over SSL/TLS.

@FooBarWidget FooBarWidget added this to the 4.0.46 milestone Jul 9, 2014

@FooBarWidget

This comment has been minimized.

Show comment
Hide comment
@FooBarWidget

FooBarWidget Jul 9, 2014

Member

Thank you for reporting this. I have marked this as high priority for 4.0.46.

Member

FooBarWidget commented Jul 9, 2014

Thank you for reporting this. I have marked this as high priority for 4.0.46.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment