/passenger

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProcessMetricsCollector doesn't print 'command not found' error correctly #1397

Closed
paisleyrob opened this Issue Mar 3, 2015 · 0 comments

Comments

Assignees

@OnixGH OnixGH

Labels
Projects
None yet
Milestone
  5.0.2
3 participants
@paisleyrob @FooBarWidget @OnixGH
@paisleyrob
Contributor

paisleyrob commented Mar 3, 2015

I've created a CentOS 6.6 chroot with nginx-1.6.2/passenger-4.0.59 for my rails application. Inside this chroot is very sparse (69 packages total) such that /bin/ps does not exist.

When I start nginx the following gets spammed into the error.log:

[ 2015-03-02 21:17:16.9083 5513/f776fb70 Pool2/Pool.h:760 ]: ERROR: The '-opid,ppid,%cpu,rss,vsize,pgid,uid,command' command failed
Backtrace:
in 'long long unsigned int Passenger::ApplicationPool2::Pool::realCollectAnalytics()' (Pool.h:867)
in 'static void Passenger::ApplicationPool2::Pool::collectAnalystics(Passenger::ApplicationPool2::PoolPtr)' (Pool.h:754)

It looks to me like ProcessMetricsCollector v4.0.59 uses ps under the hood and blows up repeatedly.

If /bin/ps is required (appears it is), I expected to see a /bin/ps: File Not Found type of error and possibly exiting.

@paisleyrob paisleyrob referenced this issue Mar 3, 2015

Merged

Error message prints command that failed #1398

@FooBarWidget FooBarWidget changed the title from /bin/ps required to ProcessMetricsCollector doesn't print 'command not found' error correctly Mar 3, 2015

@FooBarWidget FooBarWidget added the Usability label Mar 3, 2015

@FooBarWidget FooBarWidget added this to the 5.0.2 milestone Mar 3, 2015

@FooBarWidget FooBarWidget assigned OnixGH Mar 3, 2015

OnixGH pushed a commit that referenced this issue Mar 3, 2015

Daniel Knoppel (Phusion)
Log program, not command line (spotted by 
https://github.com/paisleyrob).
Closes GH-1397.
Loading status checks…
a1fe181

@OnixGH OnixGH closed this in #1398 Mar 3, 2015

OnixGH added a commit that referenced this issue Mar 3, 2015

@OnixGH
Merge pull request #1398 from paisleyrob/patch-1 
Log failed program in error message, not its command line. Closes GH-1397.
Loading status checks…
0253068
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment