New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passenger standalone should be configurable by environment variables #1661

Closed
scottjacobsen opened this Issue Nov 4, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@scottjacobsen

scottjacobsen commented Nov 4, 2015

Especially on heroku, but in general, configuring standalone with command line switches or a json config file does not work well.

A perfect example is configuring the union station key. I only want to set that in the production environment. If this could be set via an environment variable setup would be trivial - only set the UNION_STATION_KEY env var on the production servers.

As it stands I can only think of two was to only enable unionstation on production.

  1. Have the Procfile call a wrapper script to start the webserver, and have the wrapper script check for the UNION_STATION_KEY and if it is there start passenger with the --union-station-key command line param.
  2. Hack the nginx.conf.erb to only enable unionstation if that variable is defined.
@FooBarWidget

This comment has been minimized.

Show comment
Hide comment
@FooBarWidget

FooBarWidget Nov 4, 2015

Member

Good point. We should definitely allow configuration through environment variables. The Union Station setup instructions should also contain a section for Heroku.

Ping @tinco so that he knows about this issue.

Member

FooBarWidget commented Nov 4, 2015

Good point. We should definitely allow configuration through environment variables. The Union Station setup instructions should also contain a section for Heroku.

Ping @tinco so that he knows about this issue.

@FooBarWidget

This comment has been minimized.

Show comment
Hide comment
@FooBarWidget

FooBarWidget Nov 7, 2015

Member

The feature has been implemented and will be part of 5.0.22. Passenger Standalone now accepts the PASSENGER_UNION_STATION_KEY environment variable. Environment variables override the config file.

Member

FooBarWidget commented Nov 7, 2015

The feature has been implemented and will be part of 5.0.22. Passenger Standalone now accepts the PASSENGER_UNION_STATION_KEY environment variable. Environment variables override the config file.

@scottjacobsen

This comment has been minimized.

Show comment
Hide comment
@scottjacobsen

scottjacobsen Nov 7, 2015

👍 💎 🌈 😄 You guys are the best.

scottjacobsen commented Nov 7, 2015

👍 💎 🌈 😄 You guys are the best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment