New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ByeBug release breaks Passenger Enterprise's loader. #1662

Closed
phyllisstein opened this Issue Nov 6, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@phyllisstein

phyllisstein commented Nov 6, 2015

Hey Passengers! Just noticed that the most recent update to ByeBug removes eager loading of the library (see deivid-rodriguez/byebug@b77855c), so Byebug.respond_to?(:actual_port) is still false when Passenger Enterprise runs before_loading_app_code_step2. You'd have to actually call Byebug.attach before it'd be true, but that seems inutile. As an alternative, you might consider checking Kernel.byebug, which would be defined: https://github.com/deivid-rodriguez/byebug/blob/117a92184e8f37232a824945780643de9f7eb589/lib/byebug/attacher.rb#L28.

I didn't actually have an urgent need for passenger_debugger to be on, so I disabled it and this isn't urgent, but thought the heads-up might be handy. Thanks for all your hard work on Passenger!

@FooBarWidget

This comment has been minimized.

Show comment
Hide comment
@FooBarWidget

FooBarWidget Nov 6, 2015

Member

Thanks for reporting this. We'll try to fix this for 5.0.22.

Member

FooBarWidget commented Nov 6, 2015

Thanks for reporting this. We'll try to fix this for 5.0.22.

@FooBarWidget

This comment has been minimized.

Show comment
Hide comment
@FooBarWidget

FooBarWidget Nov 19, 2015

Member

The issue has been fixed and the fix will be part of 5.0.22.

Member

FooBarWidget commented Nov 19, 2015

The issue has been fixed and the fix will be part of 5.0.22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment