Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add find by PID support to passenger-status #2146

Closed
64kramsystem opened this issue Dec 12, 2018 · 1 comment
Closed

Add find by PID support to passenger-status #2146

64kramsystem opened this issue Dec 12, 2018 · 1 comment

Comments

@64kramsystem
Copy link
Contributor

@64kramsystem 64kramsystem commented Dec 12, 2018

In my company, we perform some scripted operations, which involve passenger-status.

Currently, passenger-status uses the instance name to identify the Passenger processes. This is OK, however, working with instance names in a shell scripting context is more complex than with PIDs.

I think adding a -p/--pid option to passenger-status would add this functionality in a non-intrusive and consistent way, while still being consistent both with the tool UX and the internals (Instance carries the PID).

I can easily open a PR for this; with this issue I wanted to know if this addition is acceptable or not 😄.

@CamJN
Copy link
Contributor

@CamJN CamJN commented Dec 17, 2018

This seems fine to me, @FloorD would you like to point out the contributing agreement & whatnot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants