Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: comparison of unsigned expression >= 0 is always true #2186

Closed
svoop opened this issue Mar 1, 2019 · 6 comments
Closed

Warning: comparison of unsigned expression >= 0 is always true #2186

svoop opened this issue Mar 1, 2019 · 6 comments
Milestone

Comments

@svoop
Copy link

@svoop svoop commented Mar 1, 2019

Question 1: What is the problem?

Compilation yields with gcc 8.2.0 yields the following warning which appears to render the mentioned condition ineffective:

In file included from src/agent/Watchdog/WatchdogMain.cpp:76:
src/cxx_supportlib/SystemTools/ContainerHelpers.h: In function ‘bool Passenger::_linuxAutoDetectInContainer()’:
src/cxx_supportlib/SystemTools/ContainerHelpers.h:62:22: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
    if (file.length() >= 0) {
        ~~~~~~~~~~~~~~^~~~

Question 2: Passenger version and integration mode:

open source 6.0.2

Question 3: OS or Linux distro, platform (including version):

Gentoo Linux amd64

Question 4: Passenger installation method:

RubyGems, no Gemfile

Question 5: Your app's programming language (including any version managers) and framework (including versions):

irrelevant

Question 6: Are you using a PaaS and/or containerization? If so which one?

no

@CamJN CamJN added this to the 6.0.3 milestone Mar 25, 2019
@CamJN
Copy link
Contributor

@CamJN CamJN commented Mar 25, 2019

Will be fixed in the next release.

@tilsammans
Copy link

@tilsammans tilsammans commented Jun 26, 2019

Any word on when 6.0.3 will be released?

@CamJN
Copy link
Contributor

@CamJN CamJN commented Jun 26, 2019

Unfortunately no. We're having to move to hosting our own apt & rpm packages; and that migration is taking quite a while. So I don't have a likely window for the 6.0.3 release.

@tilsammans
Copy link

@tilsammans tilsammans commented Jun 27, 2019

Thanks @CamJN I appreciate the response! Best of luck with the migration.

@CamJN
Copy link
Contributor

@CamJN CamJN commented Sep 12, 2019

Fixed in 6.0.3

@CamJN CamJN closed this Sep 12, 2019
@svoop
Copy link
Author

@svoop svoop commented Sep 14, 2019

Cool, thanks a bunch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants