PassengerPoolIdleTime cannot be set greater than 4294 ((2 ** 32 - 1) / 1000000) because of integer overflow.
Fix integer overflow when setting maxIdleTime
Thank you for catching this bug. Can I ask you to sign our contributor agreement? We need this before we can merge any patches.
Thanks for reviewing the patch.
I have sent a scan of the signed contributor agreement by e-mail.
Thank you, it has been merged now.
Give credit to Maeda Go.
I am happy to see the patch merged. Thank you.
Could it be backported to stable-4.0?
I don't think 4.x suffers from this problem. Besides, 5.0 final is slated for next month.
I will wait 5.0 but Passenger 4.x have the same problem. I found the problem in 4.0.56 at first.
Please see the following. Both options.poolIdleTime and 1000000 are 32 bit width(unsigned int). So the result of the expression cannot be greater than 2**32 - 1.