New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed nginx module building on CentOS 6 #2081

Merged
merged 1 commit into from Jun 14, 2018

Conversation

Projects
None yet
3 participants
@defanator
Contributor

defanator commented May 17, 2018

Made the same approach as in apache2 module here:
https://github.com/phusion/passenger/blob/stable-5.3/src/apache2_module/Config.cpp#L164-L165

Fixed the following error during compilation on CentOS 6.9 (gcc 4.4.7, glibc 2.12):

make -f objs/Makefile modules
make[1]: Entering directory `/home/defan/rpmbuild/BUILD/nginx-module-passenger-1.13.10'
cc -c -fPIC -pipe  -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic  -I src/core -I src/event -I src/event/modules -I src/os/unix -I /home/defan/rpmbuild/BUILD/nginx-module-passenger-1.13.10/passenger-5.2.3/src -I objs -I src/http -I src/http/modules \
		-o objs/addon/nginx_module/Configuration.o \
		passenger-5.2.3/src/nginx_module/Configuration.c
cc1: warnings being treated as errors
passenger-5.2.3/src/nginx_module/Configuration.c: In function ‘passenger_postprocess_config’:
passenger-5.2.3/src/nginx_module/Configuration.c:1024: error: ignoring return value of ‘fwrite’, declared with attribute warn_unused_result
make[1]: *** [objs/addon/nginx_module/Configuration.o] Error 1
make[1]: Leaving directory `/home/defan/rpmbuild/BUILD/nginx-module-passenger-1.13.10'
make: *** [modules] Error 2
@CamJN

This comment has been minimized.

Contributor

CamJN commented May 17, 2018

Please be sure to sign the contributor agreement.

@defanator

This comment has been minimized.

Contributor

defanator commented May 17, 2018

@CamJN submitted the agreement a few minutes ago.

@CamJN

This comment has been minimized.

Contributor

CamJN commented May 17, 2018

Ah ok, thanks. I guess the system is just being a bit slow.

@defanator

This comment has been minimized.

Contributor

defanator commented May 30, 2018

@CamJN is everything ok with the agreement and the PR?

@CamJN

This comment has been minimized.

Contributor

CamJN commented May 31, 2018

The agreement is fine, I haven't yet had time to review the PR, as I've been a bit swamped. It's on my list though.

@CamJN

This comment has been minimized.

Contributor

CamJN commented Jun 7, 2018

Could you please make the PR against the stable-5.3 branch? (I know our branch strategy is weird, sorry!)

@defanator defanator changed the base branch from master to stable-5.3 Jun 7, 2018

@defanator

This comment has been minimized.

Contributor

defanator commented Jun 7, 2018

@CamJN sure thing, done.

@CamJN CamJN merged commit 9d385d9 into phusion:stable-5.3 Jun 14, 2018

@CamJN

This comment has been minimized.

Contributor

CamJN commented Jun 14, 2018

Thanks @defanator!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment