Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow turning off friendly error pages when running standalone #77

Merged

Conversation

@adamvduke
Copy link
Contributor

@adamvduke adamvduke commented May 10, 2013

I'm not sure if I missed something in the docs, but I couldn't find a way to start passenger standalone with the friendly error pages turned off. I added a command line option --no-friendly-error-pages to allow you to make sure the friendly error pages don't get served in production. The default is still to serve them and they're only off if the new option is passed.

If there is a better way of turning them off in production I'd be curious to know what I missed.

Thanks!

starting passenger standalone with --no-friendly-error-pages
will add the corresponding nginx config
@adamvduke
Copy link
Contributor Author

@adamvduke adamvduke commented May 28, 2013

Is there any feedback as to wether this is a good or bad idea? I realize I pushed late on a Friday so the notification may have gotten buried in that weekend's emails.

@FooBarWidget
Copy link
Member

@FooBarWidget FooBarWidget commented May 31, 2013

Hi Adam, sorry for the late response, I haven't gotten around to review it until today. Your change looks good and I've merged it. Thank you for this patch.

FooBarWidget added a commit that referenced this pull request May 31, 2013
Allow turning off friendly error pages when running Passenger Standalone
@FooBarWidget FooBarWidget merged commit dae298b into phusion:master May 31, 2013
1 check passed
1 check passed
@FooBarWidget
default The Travis CI build passed
Details
@adamvduke
Copy link
Contributor Author

@adamvduke adamvduke commented May 31, 2013

👍 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants