Allow turning off friendly error pages when running standalone #77

Merged
merged 1 commit into from May 31, 2013

Conversation

Projects
None yet
2 participants
@adamvduke
Contributor

adamvduke commented May 10, 2013

I'm not sure if I missed something in the docs, but I couldn't find a way to start passenger standalone with the friendly error pages turned off. I added a command line option --no-friendly-error-pages to allow you to make sure the friendly error pages don't get served in production. The default is still to serve them and they're only off if the new option is passed.

If there is a better way of turning them off in production I'd be curious to know what I missed.

Thanks!

allow turning off friendly error pages
starting passenger standalone with --no-friendly-error-pages
will add the corresponding nginx config
@adamvduke

This comment has been minimized.

Show comment
Hide comment
@adamvduke

adamvduke May 28, 2013

Contributor

Is there any feedback as to wether this is a good or bad idea? I realize I pushed late on a Friday so the notification may have gotten buried in that weekend's emails.

Contributor

adamvduke commented May 28, 2013

Is there any feedback as to wether this is a good or bad idea? I realize I pushed late on a Friday so the notification may have gotten buried in that weekend's emails.

@FooBarWidget

This comment has been minimized.

Show comment
Hide comment
@FooBarWidget

FooBarWidget May 31, 2013

Member

Hi Adam, sorry for the late response, I haven't gotten around to review it until today. Your change looks good and I've merged it. Thank you for this patch.

Member

FooBarWidget commented May 31, 2013

Hi Adam, sorry for the late response, I haven't gotten around to review it until today. Your change looks good and I've merged it. Thank you for this patch.

FooBarWidget added a commit that referenced this pull request May 31, 2013

Merge pull request #77 from adamvduke/standalone-no-friendly-error-pages
Allow turning off friendly error pages when running Passenger Standalone

@FooBarWidget FooBarWidget merged commit dae298b into phusion:master May 31, 2013

1 check passed

default The Travis CI build passed
Details
@adamvduke

This comment has been minimized.

Show comment
Hide comment
@adamvduke

adamvduke May 31, 2013

Contributor

👍 Thanks!

Contributor

adamvduke commented May 31, 2013

👍 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment