Cannot fork in jruby -> cannot daemonize -> handle gracefully#78
Merged
Conversation
Member
|
Instead of explicitly checking for JRuby, you should use Also, could you sign the Contributor Agreement? We require this before we can accept a patch. |
When trying to daemonize the standalone on a platform that does not support fork, print to stderr and exit 1
Contributor
Author
|
Done and done |
FooBarWidget
added a commit
that referenced
this pull request
May 23, 2013
Cannot fork in jruby -> cannot daemonize -> handle gracefully
Member
|
Alright, I've merged your changes, thanks for contributing. I've also fixed the indenting. You were using spaces but our codebase uses tabs. |
Contributor
Author
|
ah, I was wondering why it was off On Thu, May 23, 2013 at 8:33 AM, Hongli Lai notifications@github.comwrote:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to daemonize the standalone in JRuby, print to stderr and exit 1 as we cannot fork
I did try spoon e.g. https://gist.github.com/ik5/448884/raw/2d945080143a2682dc6ff1862013217265262f8e/daemon.rb but not https://github.com/nicobrevin/jruby-jsvc