Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need an Icon? #114

Closed
JasonLG1979 opened this issue Mar 21, 2017 · 20 comments
Closed

Need an Icon? #114

JasonLG1979 opened this issue Mar 21, 2017 · 20 comments

Comments

@JasonLG1979
Copy link

@JasonLG1979 JasonLG1979 commented Mar 21, 2017

I installed peek in Fedora 25 via the repo and it seems to work pretty good, does just about all I need it to do. Nice little utility.

Anyway, I'm not sure if it's a bug in the packaging but peek doesn't seem to have an icon. If you don't in fact have an icon yet I'd be happy to design you one if you'd like? I'm decent at icon design. I redesigned Pithos's icon a couple years ago. https://pithos.github.io/

@phw
Copy link
Owner

@phw phw commented Mar 22, 2017

Peek has an icon, and it should show up. You probably have to run gtk-update-icon-cache or restart the shell to see it (on Arch Linux gtk-update-icon-cache runs automatically after package installation and that usually does the trick).

Anyway, the icon is not too pretty :) See https://github.com/phw/peek/blob/master/data/icons/256x256/com.uploadedlobster.peek.png . It was a quick shot I got from someone, and it served well. But it does not fit well with other icons and doesn't tell much about the app.

If you want to give this a go I am more than happy to replace this icon .

@JasonLG1979
Copy link
Author

@JasonLG1979 JasonLG1979 commented Mar 22, 2017

Peek has an icon, and it should show up. You probably have to run gtk-update-icon-cache or restart the shell to see it (on Arch Linux gtk-update-icon-cache runs automatically after package installation and that usually does the trick).

Must be a bug in the packaging. Neither gtk-update-icon-cache nor restarting the shell shows the icon.

If you want to give this a go I am more than happy to replace this icon .

What did you have in mind style wise? Tango, flat?

@JasonLG1979
Copy link
Author

@JasonLG1979 JasonLG1979 commented Mar 22, 2017

Ok, weird. The icon finally showed up after 2 reboots...

@phw
Copy link
Owner

@phw phw commented Mar 22, 2017

What did you have in mind style wise? Tango, flat?

I think Tango like is fine. It should look nice with the icons you find on a typical GNOME or Unity desktop. I found my original request for an icon: https://www.reddit.com/r/freedesign/comments/3zlcqc/request_application_logo_for_open_source_animated/

I still have no good idea about what the icon should show. A thing that changed a bit is, that Peek no longer is exclusively recording only GIFs.

Ok, weird. The icon finally showed up after 2 reboots...

Gnome Shell sometimes has some issues picking icons up, I have experienced this with other software as well. But normally running gtk-update-icon-cache or restarting the shell with Alt+F2, r does the trick for me. Also when I tested the Fedora package in a Virtual Machine it worked right away. I would say if the icons are installed at the right location this is a Gnome glitch.

@phw phw mentioned this issue Jun 20, 2017
@phw
Copy link
Owner

@phw phw commented Jun 20, 2017

See also my comment on #115

@meetdilip
Copy link
Contributor

@meetdilip meetdilip commented Aug 31, 2017

How do you want the new icon to look like ? Any pointers ?

@bertob
Copy link

@bertob bertob commented Aug 7, 2018

Hi, Tobias from the GNOME design team here.

We're working on a new icon style for GNOME, which will make it much easier to make app icons because it's simpler, more geometric, and there are fewer sizes. We will update all core GNOME apps' icons to the new style for 3.32 early next year, but some third-party apps are already starting to use them.

If you're interested in a new icon following the new guidelines I'd be happy to provide one.

@phw
Copy link
Owner

@phw phw commented Oct 22, 2018

@bertob Is your offer still valid? Would be happy to see a new icon for Peek, but lack the skills to fix this myself.

@baranpirincal
Copy link

@baranpirincal baranpirincal commented Oct 22, 2018

Hey @phw , if you still need a logo design for Peek, I can help you. If you have an idea, feel free to share with me.

@bertob
Copy link

@bertob bertob commented Oct 22, 2018

@phw sure is. This is one of the ideas we've been playing with:

image

I'm not super happy with the small text at the top, but I think as a direction it could work.

@gort818
Copy link
Contributor

@gort818 gort818 commented Oct 22, 2018

@bertob That is pretty awesome!

@phw
Copy link
Owner

@phw phw commented Nov 1, 2018

@bertob I like this very much, great work. What about just getting rid of the "PEEK" text? Then it would already work well I think.

@bertob
Copy link

@bertob bertob commented Nov 1, 2018

Ok, I think i found something that works:

image

Unfortunately Github doesn't allow uploading SVG (which is seriously weird, especially given that it does allow PPTX), so I put the hicolor and symbolic in a zip

com.uploadedlobster.peek.zip

@phw
Copy link
Owner

@phw phw commented Nov 2, 2018

Thanks, this is awesome. Also like the color. What is your recommendation on providing PNG scaled versions for this? If I read the current HIG correctly it is recommended to only provide the SVG, so this should be fine, right?

phw pushed a commit that referenced this issue Nov 2, 2018
phw pushed a commit that referenced this issue Nov 2, 2018
phw pushed a commit that referenced this issue Nov 2, 2018
@bertob
Copy link

@bertob bertob commented Nov 3, 2018

@phw yes, you don't need any PNGs.

Have a look at this MR as an example of how they new icons are used: https://gitlab.gnome.org/GNOME/geary/merge_requests/63/diffs

phw pushed a commit that referenced this issue Nov 4, 2018
@phw
Copy link
Owner

@phw phw commented Nov 4, 2018

Thanks, prepared everything in #390

@bertob Are you fine with how I credited you in these changes?

@bertob
Copy link

@bertob bertob commented Nov 4, 2018

@phw can you change my email to tbernard@gnome.org?

Also, the icon was a collaboration with @snwh, @jimmac, and @lapo, so not sure what the best way to attribute credit is.

@phw
Copy link
Owner

@phw phw commented Mar 13, 2019

Thanks a lot, finally merged

@phw phw closed this Mar 13, 2019
@bertob
Copy link

@bertob bertob commented May 3, 2019

Is there an ETA for a new release?

I'm not sure what else is happening in the code base atm, but I for one would be very happy if it included no changes other than the icon :)

@WinEunuuchs2Unix
Copy link

@WinEunuuchs2Unix WinEunuuchs2Unix commented Jun 9, 2019

Thanks for making this icon everyone. It looks nice on the desktop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants