Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Keyboard Shortcuts #23

Closed
leoherzog opened this issue Oct 5, 2016 · 7 comments
Closed

Add Keyboard Shortcuts #23

leoherzog opened this issue Oct 5, 2016 · 7 comments
Assignees
Milestone

Comments

@leoherzog
Copy link

leoherzog commented Oct 5, 2016

This project is great! Keep up the good work.

Please add a keyboard shortcut for Peek, so that all of my GIFs don't end with my cursor moving to the top middle of the window I'm recording.

@phw
Copy link
Owner

phw commented Oct 13, 2016

One of the most important things on my todo list here and my top personal annoyance when recording :) I hope to have time to get this done soon.

@phw phw added this to the Version 1.0 milestone Oct 13, 2016
phw added a commit that referenced this issue Feb 21, 2017
This allows e.g. to bind peek to global keyboard shortcuts for the desktop environment, see #23
@phw
Copy link
Owner

phw commented Feb 21, 2017

I have somewhat a solution for this. The current git master provides command line parameters to toggle the recording. So if Peek is already running you can run:

peek --start

to start recording in the running instance. Likewise you can stop with peek --stop. Most useful is maybe peek --toogle, which will start or stop recording based on the current state.

The idea is that you can bind those commands to a global kyboard shortcut inside your desktop environment, e.g. in Gnome you can configure shortcuts in the preferences.

The problem with adding shortcuts directly to Peek is, that normal application shortcuts won't help, since you normally don't have Peek focused when recording. So you need global shortcuts. Global shortcuts however require integration in each desktop environment. Or you use X directly, but with things like Wayland and Mir knocking on the door this is not a very future proof implementation. So either way, this is quite some work to support it everywhere, so I am not sure I will do that. At least not soon.

phw added a commit that referenced this issue Feb 23, 2017
Not yet configurable via UI, see #23
@phw
Copy link
Owner

phw commented Feb 23, 2017

Started work on that. Keyboard shortcut is already working in latest master, it just needs a UI to configure it and maybe it needs to be disabled on Wayland because it should not work there anyway.

What do you think is a suitable default shortcut? For now it is Ctrl+Alt+R, does that make sense or does it clash with any important default?

@Deevad
Copy link

Deevad commented Feb 23, 2017

Ctrl+Alt+R sounds good here. Thank you for the new feature!

@phw phw self-assigned this Feb 23, 2017
@lode
Copy link

lode commented Feb 26, 2017

FYI, Gnome's screencast feature (https://help.gnome.org/users/gnome-help/stable/screen-shot-record.html.en) uses Ctrl+Alt+Shift+R by default.

@phw
Copy link
Owner

phw commented Feb 28, 2017

There is now a UI for changing the keyboard shortcut:

bildschirmfoto vom 2017-02-28 14-37-56

@phw phw closed this as completed Feb 28, 2017
@Bug-Reaper
Copy link

Yo shoutouts to @phw . I just mapped peek --toggle with a keybinding and it feels so good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants