Clients (over time) should be hidden when privacy level 3 or higher is enabled.

[mwoolweaver]

In raising this issue, I confirm the following: {please fill the checkboxes, e.g: [X]}

• I have read and understood the contributors guide.
• The issue I am reporting can be replicated.
• The issue I am reporting isn't a duplicate (see FAQs, closed issues, and open issues).

How familiar are you with the the source code relevant to this issue?:

{ 1 }

---

Expected behaviour:

when enabling privacy level 3 it states:
" Hide domains and clients: Display and store all domains as "hidden" and all clients as "0.0.0.0" This disables all tables on the dashboard "
So one would assume since the graph isn't populated with any stats it wouldn't be shown.

more details on expected behavior:

i would think that when the privacy level has been enabled for any level higher than level 2 this graph should not be shown as there is no information shown in it.

Privacy Level 3 - 5 this graph should be off.

Actual behaviour:

{ Clients (over time) is shown as an empty graph when privacy level 3 or higher is enabled. }

Steps to reproduce:

{ Enable privacy level 3 and view the dashboard when logged in. }

Debug token provided by uploading pihole -d log:

{ https://tricorder.pi-hole.net/v96pimhd8r! }

Troubleshooting undertaken, and/or other relevant information:

{ Not sure how to. }

[AzureMarker]

Have you tested enabling level 3 and waiting for a few hours? The clients in the graph would then show as 0.0.0.0 starting from the moment you changed the privacy level. Previous queries are not retroactively changed.

[mwoolweaver]

will investigate. probably not a bug. will leave on for a few hours

[mwoolweaver]

pi-hole has been running for a couple hours and chart has yet to show any data at all.

[AzureMarker]

Closing the issue as there seems to be no bug.

[mwoolweaver]

The clients in the graph would then show as 0.0.0.0 starting from the moment you changed the privacy level.

this is not what's happening in my case. If you'd like I'd be willing to share a little more info via email so you can see this.

pi-hole has been running for well over 12 hrs and the graph shows no data at all.

[AzureMarker]

It may be that the 0.0.0.0 clients are not shown in the graph. I will test this tonight. You can share info with mark@pi-hole.net if you would like.

[AzureMarker]

I closed this as we are correctly not showing new client information after changing the privacy level, however I see now that you are trying to get at a different point. You want to remove the graph when there is no information to be shown. That borders on a feature request (hide charts when they do not have data), but I will keep it as an issue for now, just note that it is not a bug as this is expected behavior.

[mwoolweaver]

So if understand correctly.

When clients are being shown as 0.0.0.0 the Clients (over time) graph is supposed to be empty by design?

[AzureMarker]

Yes, you can see here that no client over time information is sent if the privacy level is 3 or higher:
https://github.com/pi-hole/FTL/blob/master/api.c#L1018

I was traveling and unable to test this until now, so sorry for any confusion.

[mwoolweaver]

That's good to know! I have resorted to using uBlock to just hide it for the time being.

So what the reason for it still being shown if it's not being populated with any data?

[AzureMarker]

No particular reason, that is just how it worked out when we added the privacy levels.

We are working on a new web interface to replace this one, and so we are trying to avoid any unnecessary changes to this web interface. Changes made to this interface will either need to be rewritten for the new web interface, or lost. I can change the new web interface to hide the charts based on privacy level, which is the best way to implement this feature. However, it will take time for that to happen, as actually shipping the new web interface has higher priority than this feature.

Preview: http://web.pi-hole.io/
Repo: https://github.com/pi-hole/web

[mwoolweaver]

as actually shipping the new web interface has higher priority than this feature.

TFW I forgot this was coming . . .

Is there a way to use it with live data?

[AzureMarker]

There is a draft PR which has some instructions for testing the API and new web interface. Note that it is still in a alpha or even pre-alpha stage: pi-hole/pi-hole#2692

[DL6ER]

Sorry for the delay, I just discovered this issue ticket. The function @mwoolweaver asks for is already there, however, a bug prevents it from working as expected. This will be fixed by #966.

[mwoolweaver]

has the release for this fix been released yet?

[AzureMarker]

No, it will be released with v5.0.