Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
By submitting this pull request, I confirm the following (please check boxes, eg [X] - no spaces) Failure to fill the template will close your PR:
Please submit all pull requests against the
How familiar are you with the codebase?: 10
This template was created based on the work of
I'd reserve type to indicate the API type (php, ftl) and version for the API version (1, 2, ect...).
Something like this:
With fallback default values:
It will more easy to improve API in the future (ex: with version 2, 3) maintaining the backward compatibility.
Mar 3, 2017
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: