Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chart.js #610

Merged
merged 1 commit into from Oct 31, 2017
Merged

Update Chart.js #610

merged 1 commit into from Oct 31, 2017

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Oct 31, 2017

By submitting this pull request, I confirm the following (please check boxes, eg [X] - no spaces) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


This PR updates the chart generating engine we use. It fixes a number of smaller issues we have seen (however, unfortunately, not that the legend cannot escape the canvas) and improves the responsiveness of the Charts notably. According the their own release notes, this update improves stability and adds a range of new features that may become handy in the future. Also, it allows us to use the current version of the documentation during development.

The version we still use, v2.3.0, is already older than one year, so this upgrade was long needed. I added two minor changes to the index page to stay consistent with our previously used style.

This template was created based on the work of udemy-dl.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added this to the v3.2 milestone Oct 31, 2017
@PromoFaux PromoFaux merged commit 8279650 into devel Oct 31, 2017
@AzureMarker AzureMarker deleted the update/Chart.js_v2.3.0-v2.7.1 branch November 1, 2017 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants