Fix for XSS bug #84
Merged
Fix for XSS bug #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pointed at the correct branch this time.
|
Thanks for this, will check it out on my lunch break! |
`json_encode` needs to call the result of `htmlspecialchars`, not visa versa!
`htmlspecialchars` does not work on arrays. This is why testing is important :^)
I actually tested this one! it works. My apologies for the previous, non-working commits-- I had to refresh my knowledge of PHP.
|
Tested. Approved. Thanks for the submission 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82
Changes proposed in this pull request:
Sanitation (via
htmlspecialchars()) of JSON data returned byapi.php, fixing an XSS bug.Pointed at the correct branch this time.