New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsmasq fails to start on raspbian with dnsmasq 2.7.6 #459

Closed
gotdibbs opened this Issue Jan 10, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@gotdibbs
Copy link

gotdibbs commented Jan 10, 2019

In raising this issue, I confirm the following: {please fill the checkboxes, e.g: [X]}

How familiar are you with the the source code relevant to this issue?:

1


Expected behaviour:

dnsmasq starts and DNS resolution is available.

Actual behaviour:

dnsmasq fails to start and DNS resolution is unavailable.

Steps to reproduce:

Switch to development branch and update.

Debug token provided by uploading pihole -d log:

5n64o3tq1c

Troubleshooting undertaken, and/or other relevant information:

I updated to the development branch to attempt to resolve an unrelated issue and found dnsmasq subsequently stayed down. The error received is below:

Jan 09 20:28:01 marida dnsmasq[17967]: dnsmasq: bad option at line 47 of /etc/dnsmasq.d/01-pihole.conf
Jan 09 20:28:01 marida systemd[1]: dnsmasq.service: Control process exited, code=exited status=1
Jan 09 20:28:01 marida systemd[1]: Failed to start dnsmasq - A lightweight DHCP and caching DNS server.

I had to disable FTL, enable dnsmasq, switch back to ftl master, then toggle dnsmasq/FTL again for things to work.

It looks like this is coming from #2570 if I had to guess. I am on dnsmasq 2.7.6 (which raspbian stretch reports as "latest"), and dhcp-name-match wasn't released until ~2.8, but I thought FTL was supposed to replace dnsmasq?

I am unsure if this breaking change was intended or not, but felt it warranted a report as I don't see documentation to the contrary.

@dschaper dschaper transferred this issue from pi-hole/pi-hole Jan 10, 2019

@jfb-pihole

This comment has been minimized.

Copy link
Member

jfb-pihole commented Jan 10, 2019

With this version of Pi-Hole, dnsmasq does not run as a separate process. The dnsmasq code is embedded in pihole-FTL. What are the contents of /etc/dnsmasq.d/o1-pihole.conf (specifically line 47)?

@gotdibbs

This comment has been minimized.

Copy link

gotdibbs commented Jan 10, 2019

@jfb-pihole Line 47 contains the dhcp-name-match as I tried to imply at the bottom of my post. I had originally thought it matched exactly what is in the PR I mentioned, but I just triple checked and see now that is not the case. Thanks for the follow up!

@DL6ER

This comment has been minimized.

Copy link
Member

DL6ER commented Jan 10, 2019

Closing as resolved. It was a typo.

@DL6ER DL6ER closed this Jan 10, 2019

@gotdibbs

This comment has been minimized.

Copy link

gotdibbs commented Jan 10, 2019

@DL6ER Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment