Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve the base 'debian:stretch-slim' image reference #16

Merged

Conversation

@lightswitch05
Copy link
Contributor

lightswitch05 commented Feb 26, 2020

Preserve the base debian:stretch-slim image reference at the cost of 4MB uncompressed.

Per discussion on #2, copying all of the files onto a scratch image does reduce overall image size by 4mb. However, it doubles the amount of disc space used on systems that already have the debian:stretch-slim base image, as there are no longer any shared layers. This pull request reconciles pihole/debian-base:latest with debian:stretch-slim - reducing overall system space through shared layers.

Also, name the stages so its a little clearer what stage files are being copied from.

See: #2 (comment)

…f 4MB uncompressed.

Per discussion on #2, copying all of the files onto a scratch image does reduce overall image size by 4mb. However, it doubles the amount of disc space used on systems that already have the `debian:stretch-slim` base image, as there are no longer any shared layers. This pull request reconciles `pihole/debian-base:latest` with `debian:stretch-slim` - reducing overall system space through shared layers.

See: #2 (comment)

Signed-off-by: Daniel <daniel@developerdan.com>
@lightswitch05 lightswitch05 force-pushed the lightswitch05:feature/preserve-shared-debian-base-image branch from ed3e88b to e50d33d Feb 26, 2020
@lightswitch05

This comment has been minimized.

Copy link
Contributor Author

lightswitch05 commented Feb 26, 2020

Anything you want to add to this @DistractionRectangle?

@diginc
diginc approved these changes Feb 26, 2020
Copy link
Member

diginc left a comment

Look good, thanks.

@DistractionRectangle

This comment has been minimized.

Copy link
Contributor

DistractionRectangle commented Feb 26, 2020

Looks good; my remark about ameliorating the regression yesterday was mistaken, I mixed up how docker treats file removal across layers (confused it with how running chown essentially duplicates files). In this case the files still count towards image size but aren't available to the container at run time.

@diginc diginc merged commit 2c75356 into pi-hole:master Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.