Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Preserve the base 'debian:stretch-slim' image reference #16
Preserve the base
Per discussion on #2, copying all of the files onto a scratch image does reduce overall image size by 4mb. However, it doubles the amount of disc space used on systems that already have the
Also, name the stages so its a little clearer what stage files are being copied from.
See: #2 (comment)
…f 4MB uncompressed. Per discussion on #2, copying all of the files onto a scratch image does reduce overall image size by 4mb. However, it doubles the amount of disc space used on systems that already have the `debian:stretch-slim` base image, as there are no longer any shared layers. This pull request reconciles `pihole/debian-base:latest` with `debian:stretch-slim` - reducing overall system space through shared layers. See: #2 (comment) Signed-off-by: Daniel <firstname.lastname@example.org>
Looks good; my remark about ameliorating the regression yesterday was mistaken, I mixed up how docker treats file removal across layers (confused it with how running chown essentially duplicates files). In this case the files still count towards image size but aren't available to the container at run time.