Preserve the base 'debian:stretch-slim' image reference #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f 4MB uncompressed. Per discussion on pi-hole#2, copying all of the files onto a scratch image does reduce overall image size by 4mb. However, it doubles the amount of disc space used on systems that already have the `debian:stretch-slim` base image, as there are no longer any shared layers. This pull request reconciles `pihole/debian-base:latest` with `debian:stretch-slim` - reducing overall system space through shared layers. See: pi-hole#2 (comment) Signed-off-by: Daniel <daniel@developerdan.com>
lightswitch05
force-pushed
the
feature/preserve-shared-debian-base-image
branch
from
ed3e88b
to
e50d33d
Compare
|
Anything you want to add to this @DistractionRectangle? |
|
Looks good; my remark about ameliorating the regression yesterday was mistaken, I mixed up how docker treats file removal across layers (confused it with how running chown essentially duplicates files). In this case the files still count towards image size but aren't available to the container at run time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Preserve the base
debian:stretch-slimimage reference at the cost of 4MB uncompressed.Per discussion on #2, copying all of the files onto a scratch image does reduce overall image size by 4mb. However, it doubles the amount of disc space used on systems that already have the
debian:stretch-slimbase image, as there are no longer any shared layers. This pull request reconcilespihole/debian-base:latestwithdebian:stretch-slim- reducing overall system space through shared layers.Also, name the stages so its a little clearer what stage files are being copied from.
See: #2 (comment)