Pi-hole Version Info at Bottom of GUI Pages

[mxmartins]

I'm running Pi-hole in a Synology Docker container. I just updated Pi-hole to pull in the new FTL version (4.3.1).

I downloaded the latest Docker image and re-installed it. On the bottom of the Dashboard GUI page (and most other GUI pages), I see the following information which does not appear correct. Should it be displaying this information in this format?

Pi-hole Version vDev (HEAD, v4.3-0-g1d43c0a) Web Interface Version vDev (HEAD, v4.3-0-g44aff72) FTL Version v4.3.1

[diginc]

After pulling the latest image, make sure you've properly re-created your container with a full docker rm or docker-compose stop before running your docker with the latest image tag.

We can compare output of docker images | grep pihole to see what image hash you have and if it is the latest.

[pssonline]

Also seeing the above issue running Pi-hole in a docker on an unRaid box. Output is
pihole/pihole latest 07d7ef169eb9 13 hours ago 273MB

Not entirely sure how to resolve this as I've not changed any of the template or repository settings?

[mxmartins]

I’ve deleted the container multiple times, and made sure all data files in Docker were deleted. But I get the same problem…

Pi-hole Version vDev (HEAD, v4.3-0-g1d43c0a) Web Interface Version vDev (HEAD, v4.3-0-g44aff72) FTL Version v4.3.1

root@DiskStation:~# docker images | grep pihole

pihole/pihole latest 07d7ef169eb9 5 hours ago 273MB
pihole/pihole e4feea084a98 3 days ago 273MB
pihole/pihole 501ab5b47e04 2 weeks ago 304MB
pihole/pihole fafd90299bac 3 months ago 299MB

Can you please look at this output and tell me if something is not right? I’m using the Latest image from the Synology Docker registry. I’ve done updates before and never ran into this issue before. I’m not sure what is really going on.

[diginc]

I confirmed this issue, it is because of the change in #454. I've attempted to resolve this by running a git tag fetch but it seems broken due to the shallow clone still. Will need to see what else can be done on the docker side, other wise maybe the web page can lookup the version the same way the command pihole version does, because that actually works.

[AzureMarker]

You could clone a few commits further than just one, which is what pi-hole/pi-hole#2738 did to solve a similar issue.

[pssonline]

Apologies for the completely non-savvy post but where are we with this please?

[diginc]

The branch metadata had to be pulled in to fix, opening a PR to resolve now.

[mxmartins]

Problem resolved. Thank you for the help… From: Adam Hill <notifications@github.com> Sent: Sunday, June 23, 2019 12:32 PM To: pi-hole/docker-pi-hole <docker-pi-hole@noreply.github.com> Cc: mxmartins <mmartins@aol.com>; Author <author@noreply.github.com> Subject: Re: [pi-hole/docker-pi-hole] Pi-hole Version Info at Bottom of GUI Pages (#469) Closed #469 <#469> via #478 <#478> . — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#469?email_source=notifications&email_token=AL7ZG72DE4N2SY7CHYOYO73P366RBA5CNFSM4HR7YTA2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSD7DS3A#event-2432579948> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AL7ZG77AQUS6Y4IOVMVEXLDP366RBANCNFSM4HR7YTAQ> . <https://github.com/notifications/beacon/AL7ZG75GOS5PACII3N2RLE3P366RBA5CNFSM4HR7YTA2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSD7DS3A.gif>

[pssonline]

Thank you.