Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to update base image to debian stretch #221

Closed
wants to merge 4 commits into from
Closed

Attempting to update base image to debian stretch #221

wants to merge 4 commits into from

Conversation

@halkeye
Copy link
Contributor

@halkeye halkeye commented Jan 26, 2018

This is mostly to fix pi-hole/pi-hole#1392 for me, which shows we need a more modern version of dnsmasq.
the one in jessie is a couple years old now.

I am not sure if I should be updating the docker templates, but they were in the branch to start with

@halkeye
Copy link
Contributor Author

@halkeye halkeye commented Jan 26, 2018

@diginc I'm not sure if anything in #196 is impacted, I don't think so though.

@halkeye
Copy link
Contributor Author

@halkeye halkeye commented Jan 26, 2018

https://discourse.pi-hole.net/t/running-dnscrypt-and-dnssec/1463/8 mentions another way of forcing dnsmasq to be pulled from stretch but I think a full base upgrade is better than trying to mix versions.

@halkeye
Copy link
Contributor Author

@halkeye halkeye commented Jan 26, 2018

I have no idea what that test is testing? I'm guessing if dnsmasq fails when a hostname/name is provided instead of an IP?

@diginc
Copy link
Member

@diginc diginc commented Jan 26, 2018

#211 already started using stretch.

@diginc
Copy link
Member

@diginc diginc commented Jan 26, 2018

I think tests are failing for the same reason my dev branch update did. The non interactive is not persisting down into the install script and it still hangs on the perl TERM not set error

+ debconf-apt-progress -- apt-get --yes --no-install-recommends install apt-utils dialog dhcpcd5 git whiptail
debconf: unable to initialize frontend: Dialog
debconf: (TERM is not set, so the dialog frontend is not usable.)
debconf: falling back to frontend: Readline
debconf: unable to initialize frontend: Readline
debconf: (Can't locate Term/ReadLine.pm in @INC (you may need to install the Term::ReadLine module) (@INC contains: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base .) at /usr/share/perl5/Debconf/FrontEnd/Readline.pm line 7.)
debconf: falling back to frontend: Teletype

Try this build local to confirm

./Dockerfile.py --no-build ; docker build --pull --no-cache --cache-from="diginc/pi-hole:debian_amd64,pi-hole:debian_amd64" -f Dockerfile_debian_amd64 -t pi-hole:debian_amd64 .

@diginc
Copy link
Member

@diginc diginc commented Jan 26, 2018

Actually looks like you resolved that already. You might try merging my changes from #211 into your and see if that resolves your failures.

@halkeye
Copy link
Contributor Author

@halkeye halkeye commented Jan 27, 2018

@diginc
Copy link
Member

@diginc diginc commented Jan 27, 2018

I merged locally and the same test fail for test/test_start.py::test_ServerIP_invalid_IPs_triggers_exit_error[debian-amd64--e ServerIP="1.2.3.z"-ServerIP Environment variable (1.2.3.z) doesn't appear to be a valid IPv4 address-1] FAILED persisted.

Stretch's netcat/nc is probably newer and has a seperate error message when DNS isn't available now. I've resolved it by changing the implementation to not look for a specific error message, just a empty result from netcat is good enough to confirm that the user entered a valid IP I believe.

@diginc
Copy link
Member

@diginc diginc commented Jan 27, 2018

I've merged your commits into #211 along with the fixes to the test.

@halkeye halkeye closed this Jan 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants