Simplify Dockerfile configuration. #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightswitch05
force-pushed
the
feature/consolidate-dockerfiles
branch
from
20b78f7
to
d4c3a50
Compare
|
Sorry about the conflicts, could you merge dev in? |
|
Sorry, I just saw this @diginc - no problem! |
* Simplify docker builds by consolidating all arch's into a single Dockerfile and using ARGS for various differences * Introduce docker-compose based builds (build.yml) for simple management of the various args differences Signed-off-by: Daniel <daniel@developerdan.com>
lightswitch05
force-pushed
the
feature/consolidate-dockerfiles
branch
from
d4c3a50
to
6939ea0
Compare
|
Conflicts fixed. I know there has been some discussions about building multi-arch images and issues with manifests. This change does introduce |
|
I might do some more work in this project in the coming days. I’d like to base that work on these changes. Anything particular holding this back? Or just things moving slowly? |
diginc
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify Dockerfile configuration by dropping the various Dockerfile flavors.
Description
Motivation and Context
My original goal tonight was to introduce GitHub actions, but I quickly realized there is a lot of moving parts with this build. After some investigation, it seemed some complexities could be simplified - particularly with the various Dockerfile flavors.
How Has This Been Tested?
Just running local builds. While I did switch the build tool from plain Docker to docker-compose - I tried to keep the
Dockerfile.pyinterface untouched to reduce further complications.Types of changes
Checklist:
☝️ I've changed the build logic, but I think that falls outside of the 'documentation' category.