Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the automatic cloudflared #858

Merged
merged 3 commits into from Feb 20, 2023
Merged

Remove the automatic cloudflared #858

merged 3 commits into from Feb 20, 2023

Conversation

Cyb3r-Jak3
Copy link
Contributor

@Cyb3r-Jak3 Cyb3r-Jak3 commented Feb 18, 2023

…emoved

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

Removes old documentation about using cloudflared service install --legacy

How does this PR accomplish the above?:

Remove a section of the cloudflared guide.

Issue link: #679


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@netlify
Copy link

netlify bot commented Feb 18, 2023

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit ff9b117
🔍 Latest deploy log https://app.netlify.com/sites/pihole-docs/deploys/63f30ede471a8500082cb26a
😎 Deploy Preview https://deploy-preview-858--pihole-docs.netlify.app/guides/dns/cloudflared
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. Could you also please fix the admonition on line 51 while you're working on that file?

@yubiuser yubiuser linked an issue Feb 19, 2023 that may be closed by this pull request
@Cyb3r-Jak3
Copy link
Contributor Author

Fixed

@yubiuser yubiuser merged commit 3464eb9 into pi-hole:master Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloudflared installation fails with current cloudflared version
2 participants