Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

line 391 of /advanced/Scripts/piholeDegub.sh. 'Teminate' should be 'Terminate' #1625

Closed
award28 opened this Issue Jul 20, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@award28
Copy link

commented Jul 20, 2017

In raising this issue, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your issue:

How familiar are you with the codebase?:
Not very familiar, noticed typo on debugging.

1


[BUG REPORT | OTHER]:

Please submit your feature request here, so it is votable by the community. It's also easier for us to track.

[BUG | ISSUE] Expected Behaviour:

[BUG | ISSUE] Actual Behaviour:

[BUG | ISSUE] Steps to reproduce:

(Optional) Debug token generated by pihole -d:

<token>

This template was created based on the work of udemy-dl.

@WaLLy3K

This comment has been minimized.

Copy link
Collaborator

commented Jul 20, 2017

Hey @award28, thanks for the report. I can see the issue you mention here and can confirm that it'll be fixed in the next release, due to a complete re-write of the debug script.

@award28

This comment has been minimized.

Copy link
Author

commented Jul 20, 2017

Glad I could help. Thank you @WaLLy3K.

@WaLLy3K WaLLy3K added this to the v3.2 milestone Oct 10, 2017

@jacobsalmela

This comment has been minimized.

Copy link
Member

commented Dec 8, 2017

Resolved in v3.2 (#1585)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.