Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
dhcpcd on Ubuntu? Why not the native dhclient? #1713
In raising this issue, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your issue:
How familiar are you with the codebase?:
ISSUE Expected Behaviour:
ISSUE Actual Behaviour:
As you can imagine, it gave me a good couple hours of head scratching until I stumbled across the new config file and realized my dhcp client had been replaced. Looking up basic-install.sh confirmed that that's what happened.
ISSUE Steps to reproduce:
I'm less familiar with Raspian systems so it may be absolutely necessary there - but it would be nice for installation on other systems to not swap out network daemons without much warning.
Or is there another reason Pi-hole has favored dhcpcd for so long that I'm simply unaware of?
We are currently primarily installed on Raspberry Pi devices, and the Raspbian distro for the RPi devices all use
We've discussed often ways to get away from the necessity of
Since we originally were designed for the RPi line of hardware and had the goal of taking a fresh Raspbian image and handle as much as we could for the users who may not have the requisite skills to do such IP management, we elected to go with the default and de-facto method for IP assignment used in Raspbian. I am in agreement that this is not the best method, but with the myriad of methods used in various distros to assign IP addressing and the current push to use static/reserved leases for devices and have the router assign a known IP to the Pi-hole, there's just a whole lot of changes that need to be put in place and tested. It's something that we are aware of and something we are working on, we also have to take in to account currently installed configurations and determining how to update those to bring them up to the new method when we decide on the direction to go.
So thanks for the issue and it's something we have been looking at but all the pieces are not quite there to orchestrate everything.
Thank you for the detailed response.
I see your point about fragmentation. What may be a relatively small change in this immediate case is compounded by many other similar systems, as well as upgrade logic for each of them and to each of them from the current state. That would turn into a lot to manage very quickly, and probably be error-prone for the first few iterations at least. I understand why it hasn't been done yet - and fully expect it might take some time still.
I think the way way Pi-hole.net puts so many Linux distro icons on the front page is what set my expectations regarding how well it worked with Ubuntu. Perhaps we could find somewhere to document the fact that the installer installs
That would at least help steer expectations in the meanwhile. It looks like it's hard to submit a pull request to that page. ;-)
I agree that we should be more up front about the two major requirements of
This is a long-standing issue and the scope of it is so vast that it's hard to manage. I've often thought about taking out the IP addressing functions completely, and if we had a FAQ that was populated with the different OSes and the different methods to set a static IP we may be able to remove it and point users via whiptail to a page that shows
Or at the least modify the install to ask users if we should set an IP for them and let them know that we have modified
@AndrewHeim I have added a section on IP addressing to our HW/SW requirements page. It doesn't completely solve the issue, but hopefully addresses your request on this ticket. If it does, I'll close it and we can continue the discussion on #629
@jacobsalmela I really like those comments. (I don't mind being the poster child for confusion in this case, either.)
While it is helpful, I don't want to scare away folks who might want to run pi-hole on non-Raspian distros. Perhaps adding a line to the effect of "Installing pi-hole will likely work without incident on non-Raspian distros, but may cause later confusion because of this conflict. Just be aware."
That being said, I like the changes proposed on #629 - I think that could even further reduce this confusion. Once that is merged, we can update this doc to say something to the effect of "if you're on a non-Raspian distro, use the DHCP mode".
I think we can close this issue.
I just want to point out here that Raspbian for PC and Mac does exist. Dealing with this single "fragment" would be a big help for people who want to try this out on a spare partition or old machine. Install Raspbian for PC, Install Pi-hole, run an extra script (or something) and be up and running.
The message on the front page then gets a little bit simpler and easier to understand: "Made for Raspbian for PC, works on these other distributions with some modifications."