Failure to download FTL binary should stop script.

[dschaper]

In raising this issue, I confirm the following: {please fill the checkboxes, e.g: [X]}

• I have read and understood the contributors guide.
• The issue I am reporting can be replicated.
• The issue I am reporting isn't a duplicate (see FAQs, closed issues, and open issues).

How familiar are you with the the source code relevant to this issue?:

10

Expected behaviour:

A failure to get the FTL binary should be a dependency that is checked before the bulk of the script runs. This will allow for a failure of the script and no modification of the target system. Will allow re-runs of the script to be easier, no need to have to edit /etc/resolv.conf to change the localhost entry to an upstream.

Actual behaviour:

FTL failures happen far in to the process after dependencies are installed and resolv.conf has already been modified to 127.0.0.1.

Steps to reproduce:

Just run the installer or try to update.

Debug token provided by uploading pihole -d log:

N/A

[AzureMarker]

Pushed back to v4.2 so we can get v4.1 out soon.

[dschaper]

Fixed in #2600