replace 'git -C' with long version #1009

Merged
merged 2 commits into from Dec 22, 2016

Projects

None yet

3 participants

@bcambl
Member
bcambl commented Dec 22, 2016
  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

  • 8

The -C argument was introduced in git 1.8.4. CentOS 7.3 at the time of this commit provides v1.8.3.1.
see: https://git.kaarsemaker.net/git/commit/44e1e4d67d5148c245db362cc48c3cc6c2ec82ca/

Fixes #1004

@bcambl bcambl replace 'git -C' with long version
The -C argument was introduced in git 1.8.4. CentOS 7.3 at the time of this commit provides v1.8.3.1.
see: https://git.kaarsemaker.net/git/commit/44e1e4d67d5148c245db362cc48c3cc6c2ec82ca/

Fixes #1004
c9c28cb
@PromoFaux PromoFaux added this to the v2.11 milestone Dec 22, 2016
@dschaper
Member

Okay, not a biggie to change. Can we to that in curly braces though so it doesn't spawn a subshell?

@bcambl
Member
bcambl commented Dec 22, 2016

np

@dschaper
Member

Merci, I've just been getting bit by the scopes and environment variables with subshells, so as much as we can keep things in the parent shell the easier to trace down some mysto bugs.

@bcambl bcambl replace subshell with command chain
cbf84c1
@dschaper
Member
dschaper commented Dec 22, 2016 edited

Approved

Approved with PullApprove

@bcambl bcambl merged commit 8f402f5 into pi-hole:development Dec 22, 2016

4 checks passed

codacy/pr Good work! A positive pull request.
Details
code-review/pullapprove Approved by bcambl, dschaper
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@DL6ER DL6ER added a commit that referenced this pull request Dec 24, 2016
@DL6ER DL6ER replace 'git -C' with long version (see #1009) 0276c72
@Mcat12 Mcat12 referenced this pull request Dec 24, 2016
Merged

update.sh code refactoring #1033

5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment