Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug version detection improvements #1296

Merged
merged 2 commits into from Mar 5, 2017

Conversation

Projects
None yet
2 participants
@dschaper
Copy link
Member

commented Mar 5, 2017

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


Clean up debug version detection and logic.

This template was created based on the work of udemy-dl.

dschaper added some commits Mar 5, 2017

Version check amalgamation and removal of && || logic.
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
Shellchecking.
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
@DL6ER

This comment has been minimized.

Copy link
Member

commented Mar 5, 2017

Approved

Approved with PullApprove

@dschaper dschaper merged commit 8e2b51b into development Mar 5, 2017

5 checks passed

codacy/pr Good work! A positive pull request.
Details
code-review/pullapprove Approved by DL6ER, dschaper
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@dschaper dschaper deleted the fix/debugVersion branch Mar 5, 2017

DL6ER added a commit that referenced this pull request Mar 10, 2017

Merge pull request #1296 from pi-hole/fix/debugVersion
Debug version detection improvements

@DL6ER DL6ER referenced this pull request Mar 10, 2017

Merged

Pi-hole Core v2.13.2 #1312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.