New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend additions for aufit log feature #1399

Merged
merged 1 commit into from Jun 27, 2017

Conversation

Projects
None yet
3 participants
@DL6ER
Member

DL6ER commented Apr 22, 2017

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?: 10


See pi-hole/AdminLTE#479

This template was created based on the work of udemy-dl.

@DL6ER DL6ER added the Enhancement label Apr 22, 2017

@DL6ER DL6ER added this to the v3.0 milestone Apr 22, 2017

@DL6ER DL6ER requested review from PromoFaux and Mcat12 Apr 22, 2017

@PromoFaux

This comment has been minimized.

Member

PromoFaux commented Apr 22, 2017

Approved

Approved with PullApprove

@PromoFaux

This comment has been minimized.

Member

PromoFaux commented Apr 22, 2017

Although, there needs to be a way to remove items, too.

@DL6ER

This comment has been minimized.

Member

DL6ER commented Apr 23, 2017

I will add a Undo button that will remove the very last line that was added to the audit file. I see no point in being able to reset the list via the web interface - you can still do that very easily by hand over SSH. but let's see if anyone really needs that.

@DL6ER DL6ER changed the title from Backend additions for aufit log feature to [WIP] Backend additions for aufit log feature Apr 23, 2017

@PromoFaux

This comment has been minimized.

Member

PromoFaux commented Apr 23, 2017

Why not one for each? In the same way that you can remove individual entries from the black and whitelists....

@DL6ER DL6ER modified the milestones: v3.1, v3.0 Apr 24, 2017

@DL6ER

This comment has been minimized.

Member

DL6ER commented Apr 24, 2017

Pushing this feature back to a future release, since I don't want this to be a blocker (some things are still being actively discussed)

@Mcat12 Mcat12 modified the milestones: v3.2, v3.1 Jun 10, 2017

@Mcat12

This comment has been minimized.

Member

Mcat12 commented Jun 10, 2017

Aligned this PR's milestone with its corresponding web PR's milestone (v3.2)

@DL6ER DL6ER changed the title from [WIP] Backend additions for aufit log feature to Backend additions for aufit log feature Jun 27, 2017

@DL6ER DL6ER merged commit e9d81fc into development Jun 27, 2017

5 checks passed

codacy/pr Good work! A positive pull request.
Details
code-review/pullapprove Approved by DL6ER, PromoFaux
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@DL6ER DL6ER deleted the new/auditlog branch Jun 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment