Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gravity generation when IPv6 CIDR is present #1564

Merged
merged 1 commit into from Jun 26, 2017

Conversation

Projects
None yet
2 participants
@Mcat12
Copy link
Member

Mcat12 commented Jun 26, 2017

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:
10


Fixes Discourse issue: https://discourse.pi-hole.net/t/ipv6-aaaa-dns-issue/3830
Since IPv6 CIDR is not needed anyways, we can also look into removing it in the installer.

This template was created based on the work of udemy-dl.

@Mcat12 Mcat12 added the Bug: fixed label Jun 26, 2017

@DL6ER

DL6ER approved these changes Jun 26, 2017

@DL6ER

This comment has been minimized.

Copy link
Member

DL6ER commented Jun 26, 2017

Approved

@Mcat12 Mcat12 merged commit 89a22de into development Jun 26, 2017

5 checks passed

codacy/pr Good work! A positive pull request.
Details
code-review/pullapprove Approved by DL6ER, Mcat12
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@Mcat12 Mcat12 deleted the fix/ipv6-cidr branch Jun 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.