Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow underscore ( _ ) in domains #1571

merged 2 commits into from Jun 30, 2017


None yet
4 participants
Copy link

DL6ER commented Jun 29, 2017

By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:


Fixes unreported issue with adding domains like using the command line.

This template was created based on the work of udemy-dl.

Allow underscore ( _ ) in domains. Fixes unreported issue with adding…
… domains like ``

Signed-off-by: DL6ER <>

@DL6ER DL6ER added the Bug: fixed label Jun 29, 2017

@DL6ER DL6ER referenced this pull request Jun 29, 2017


Allow underscore ( _ ) in domains #533

5 of 5 tasks complete

This comment has been minimized.

Copy link
Member Author

DL6ER commented Jun 29, 2017

@WaLLy3K Do you want to change something in this PR?

Check validity of domain
* Use bash instead of sed to convert to lower case
* Perl regex is directly ported from AdminLTE #533

@WaLLy3K WaLLy3K merged commit ec4e978 into development Jun 30, 2017

5 checks passed

codacy/pr Good work! A positive pull request.
code-review/pullapprove Approved by DL6ER, WaLLy3K
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
license/cla Contributor License Agreement is signed.

@WaLLy3K WaLLy3K deleted the tweak/domain_check_allow_underscore branch Jun 30, 2017


This comment has been minimized.

Copy link

pralor commented Feb 27, 2018

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.