Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Web Admin from printing restartdns colour codes #1575

Merged
merged 3 commits into from Jul 15, 2017

Conversation

Projects
None yet
3 participants
@WaLLy3K
Copy link
Collaborator

WaLLy3K commented Jul 1, 2017

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

9


Resolves this issue:
image

Test by changing interface listening behaviour, it should not print anything. Then perform echo "asdsad" | sudo tee "/etc/dnsmasq.d/foobar.conf" and attempt again. Should print dnsmasq error message.

@dschaper
Copy link
Member

dschaper left a comment

LGTM

@dschaper

This comment has been minimized.

Copy link
Member

dschaper commented Jul 14, 2017

@WaLLy3K Can you check the Merge Conflicts on this one?

@PromoFaux
Copy link
Member

PromoFaux left a comment

Approved. Tested. Reviewed.

@PromoFaux

This comment has been minimized.

Copy link
Member

PromoFaux commented Jul 15, 2017

Approved

@PromoFaux PromoFaux merged commit 3631d13 into development Jul 15, 2017

5 checks passed

codacy/pr Good work! A positive pull request.
Details
code-review/pullapprove Approved by PromoFaux, WaLLy3K
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@PromoFaux PromoFaux deleted the restartdns-colour-fix branch Jul 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.